Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for converting sparse bool tensors to dense #50019

Closed
wants to merge 2 commits into from

Conversation

NathanHowell
Copy link
Contributor

Fixes #49977

@facebook-github-bot
Copy link
Contributor

Hi @NathanHowell!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 3, 2021

💊 CI failures summary and remediations

As of commit 9825f34 (more details on the Dr. CI page):


None of the CI failures appear to be your fault 💚



1 job timed out:

  • pytorch_linux_bionic_py3_8_gcc9_coverage_test1

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 13 times.

@NathanHowell
Copy link
Contributor Author

@facebook-github-bot cla

@NathanHowell
Copy link
Contributor Author

@mruberry any chance you can kick that failed test?

@ezyang ezyang requested a review from mruberry January 5, 2021 15:20
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc'ed mruberry in case he has testing guidance

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@mruberry
Copy link
Collaborator

mruberry commented Jan 5, 2021

cc'ed mruberry in case he has testing guidance

Looks OK to me. Our sparse test suite is a little wonky which means this test has to jump through some hoops it normally wouldn't, but it looks like it's jumping through the correct hoops.

@facebook-github-bot
Copy link
Contributor

@ezyang merged this pull request in c517e15.

@NathanHowell NathanHowell deleted the issue/49977 branch January 7, 2021 04:04
hwangdeyu pushed a commit to hwangdeyu/pytorch that referenced this pull request Jan 14, 2021
Summary:
Fixes pytorch#49977

Pull Request resolved: pytorch#50019

Reviewed By: smessmer

Differential Revision: D25782045

Pulled By: ezyang

fbshipit-source-id: a8389cbecb7e79099292a423a6fd8ac28631905b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure when converting a sparse boolean tensor to a dense tensor
5 participants