Improve torch.linalg.qr #50046
Improve torch.linalg.qr #50046
Conversation
💊 CI failures summary and remediationsAs of commit 92b0225 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 13 times. |
mruberry
added
the
triaged
Codecov Report
@@ Coverage Diff @@
## master #50046 +/- ##
=======================================
Coverage 80.66% 80.66%
=======================================
Files 1899 1899
Lines 206066 206066
=======================================
+ Hits 166224 166225 +1
+ Misses 39842 39841 -1 |
|
@mruberry as promised, here is a follow up PR to fix all the remaining details of PR #47764. (tests are still running, I'll check their status tomorrow) |
|
@mruberry tests seem to be ok and the failure unrelated so it's ready for review |
|
Docs failures actually are real, although they're very hard to parse: Just ping me when this is ready to merge. |
fixed the issue, the docs jobs are now green. Other jobs are still in-progress though, I'll take care to ping you when they are green for real |
|
@mruberry all tests are green 👍 |
There was a problem hiding this comment.
@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: This is a follow up of PR pytorch#47764 to fix the remaining details. Pull Request resolved: pytorch#50046 Reviewed By: zou3519 Differential Revision: D25825557 Pulled By: mruberry fbshipit-source-id: b8e335e02265e73484a99b0189e4cc042828e0a9
This is a follow up of PR #47764 to fix the remaining details.