Implementation of torch::cuda::synchronize #50072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit c59c611 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 7 times. |
Codecov Report
@@ Coverage Diff @@
## master #50072 +/- ##
==========================================
- Coverage 80.67% 80.66% -0.01%
==========================================
Files 1899 1899
Lines 205951 205959 +8
==========================================
- Hits 166149 166146 -3
- Misses 39802 39813 +11 |
|
I think CUDAHooksInterface is the correct entry, no need to add a method to DeviceGuard. |
jbschlosser
changed the title
glaringlee
approved these changes
Jan 6, 2021
There was a problem hiding this comment.
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jbschlosser merged this pull request in 7d9eb6c. |
hwangdeyu
pushed a commit
to hwangdeyu/pytorch
that referenced
this pull request
Jan 14, 2021
Summary: Adding `torch::cuda::synchronize()` to libtorch. Note that the implementation here adds a new method to the `CUDAHooksInterface`. An alternative that was suggested to me is to add a method to the `DeviceGuard` interface. Fixes pytorch#47722 Pull Request resolved: pytorch#50072 Reviewed By: H-Huang Differential Revision: D25804342 Pulled By: jbschlosser fbshipit-source-id: 45aa61d7c6fbfd3178caf2eb5ec053d6c01b5a43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
torch::cuda::synchronize()to libtorch. Note that the implementation here adds a new method to theCUDAHooksInterface. An alternative that was suggested to me is to add a method to theDeviceGuardinterface.Fixes #47722