Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using an unnecessary scalar_to_tensor(..., device) call. #50114

Closed
wants to merge 7 commits into from

Conversation

gchanan
Copy link
Contributor

@gchanan gchanan commented Jan 5, 2021

Stack from ghstack:

In this case, the function only dispatches on cpu anyway.

Differential Revision: D25790155

In this case, the function only dispatches on cpu anyway.
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 5, 2021

💊 CI failures summary and remediations

As of commit da49573 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 45 times.

…ll."

In this case, the function only dispatches on cpu anyway.

Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll."

In this case, the function only dispatches on cpu anyway.

Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
@gchanan gchanan requested a review from mruberry January 5, 2021 22:37
…ll."

In this case, the function only dispatches on cpu anyway.

Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll."

In this case, the function only dispatches on cpu anyway.

Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
…ll."

In this case, the function only dispatches on cpu anyway.

Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
Copy link
Collaborator

@mruberry mruberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

…ll."

In this case, the function only dispatches on cpu anyway.

Differential Revision: [D25790155](https://our.internmc.facebook.com/intern/diff/D25790155)
@gchanan
Copy link
Contributor Author

gchanan commented Jan 11, 2021

this is tested, see: #50376.

@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in b001c4c.

@facebook-github-bot facebook-github-bot deleted the gh/gchanan/350/head branch January 15, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants