Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document single op replacement #50116

Closed
wants to merge 5 commits into from

Conversation

ansley
Copy link

@ansley ansley commented Jan 5, 2021

Stack from ghstack:

Differential Revision: D25803457

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 5, 2021

💊 CI failures summary and remediations

As of commit 173fb5a (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 18 times.

ansley pushed a commit that referenced this pull request Jan 5, 2021
ghstack-source-id: 4e40784cfdfa1268a9cfb98c8c68734e19291a3f
Pull Request resolved: #50116
@ansley ansley requested a review from jamesr66a January 6, 2021 14:01
ansley pushed a commit that referenced this pull request Jan 6, 2021
ghstack-source-id: 83c5ff8843edf5659919928d76f5b8dbb6c3ef37
Pull Request resolved: #50116
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

torch/fx/examples/replace_op.py Outdated Show resolved Hide resolved
torch/fx/examples/replace_op.py Outdated Show resolved Hide resolved
ansley pushed a commit that referenced this pull request Jan 8, 2021
ghstack-source-id: b5f3480a1eb890aff5f325f3898653cb47a50530
Pull Request resolved: #50116
@ansley ansley requested a review from jamesr66a January 8, 2021 21:08
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I added some more incremental improvement suggestions. Feel free to land when ready

torch/fx/examples/replace_op.py Outdated Show resolved Hide resolved
torch/fx/examples/replace_op.py Outdated Show resolved Hide resolved
torch/fx/examples/replace_op.py Show resolved Hide resolved
torch/fx/examples/replace_op.py Outdated Show resolved Hide resolved
torch/fx/examples/replace_op.py Show resolved Hide resolved
ansley pushed a commit that referenced this pull request Jan 9, 2021
ghstack-source-id: d32e739ceeb309801553bdff58f69bf3f98ce289
Pull Request resolved: #50116
@facebook-github-bot
Copy link
Contributor

@ansley merged this pull request in ba1ce71.

@facebook-github-bot facebook-github-bot deleted the gh/ansleyadelaide/27/head branch January 12, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants