New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document single op replacement #50116
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 173fb5a (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 18 times. |
[ghstack-poisoned]
ghstack-source-id: 4e40784cfdfa1268a9cfb98c8c68734e19291a3f Pull Request resolved: #50116
[ghstack-poisoned]
ghstack-source-id: 83c5ff8843edf5659919928d76f5b8dbb6c3ef37 Pull Request resolved: #50116
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Differential Revision: [D25803457](https://our.internmc.facebook.com/intern/diff/D25803457) [ghstack-poisoned]
ghstack-source-id: b5f3480a1eb890aff5f325f3898653cb47a50530 Pull Request resolved: #50116
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I added some more incremental improvement suggestions. Feel free to land when ready
Differential Revision: [D25803457](https://our.internmc.facebook.com/intern/diff/D25803457) [ghstack-poisoned]
ghstack-source-id: d32e739ceeb309801553bdff58f69bf3f98ce289 Pull Request resolved: #50116
Stack from ghstack:
Differential Revision: D25803457