Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstring for Proxy #50145

Closed
wants to merge 2 commits into from

Conversation

ansley
Copy link

@ansley ansley commented Jan 6, 2021

Stack from ghstack:

Differential Revision: D25854281

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 6, 2021

💊 CI failures summary and remediations

As of commit b704829 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 6 times.

ansley pushed a commit that referenced this pull request Jan 6, 2021
ghstack-source-id: 6313d2d79ae9d32a03ee4b75774db66f6ec0e380
Pull Request resolved: #50145
@ansley ansley requested a review from jamesr66a January 6, 2021 16:46
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Probably also want to add an autoclass entry for this on the docs source: https://github.com/pytorch/pytorch/blob/master/docs/source/fx.rst

(instructions for building and viewing the rendered docs are here: https://github.com/pytorch/pytorch/blob/master/CONTRIBUTING.md#writing-documentation)

torch/fx/proxy.py Outdated Show resolved Hide resolved
torch/fx/proxy.py Outdated Show resolved Hide resolved
torch/fx/proxy.py Outdated Show resolved Hide resolved
torch/fx/proxy.py Outdated Show resolved Hide resolved
ansley pushed a commit that referenced this pull request Jan 7, 2021
ghstack-source-id: 84129c7f9217266931f3ed17eb15686716c9f1f8
Pull Request resolved: #50145
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #50145 (b704829) into gh/ansleyadelaide/28/base (321b988) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@                      Coverage Diff                      @@
##           gh/ansleyadelaide/28/base   #50145      +/-   ##
=============================================================
- Coverage                      80.69%   80.59%   -0.10%     
=============================================================
  Files                           1902     1902              
  Lines                         206335   206335              
=============================================================
- Hits                          166494   166304     -190     
- Misses                         39841    40031     +190     

@ansley ansley requested a review from jamesr66a January 8, 2021 14:41
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@facebook-github-bot
Copy link
Contributor

@ansley merged this pull request in 080a097.

@ansley ansley deleted the gh/ansleyadelaide/28/head branch January 15, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants