Fix deprecation warning in scalar_type_analysis

[malfet]

No description provided.

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 6d0e518 (more details on the Dr. CI page):

---

• 1/1 failures possibly* introduced in this PR
  • 1/1 non-CircleCI failure(s)

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 10 times.

[facebook-github-bot]

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[janeyx99]

Throughout the codebase, I see invocations of this function called as isIntegralType(t, /*includeBool=*/ false). Why do we have that/should we be consistent here?

[samestep]

Throughout the codebase, I see invocations of this function called as isIntegralType(t, /*includeBool=*/ false). Why do we have that/should we be consistent here?

lol we could do this :P https://www.fluentcpp.com/2018/12/14/named-arguments-cpp/

[malfet]

Throughout the codebase, I see invocations of this function called as isIntegralType(t, /*includeBool=*/ false). Why do we have that/should we be consistent here?

Because "false" argument is quite confusing without knowing the function signature. A rather common workaround for this problem is to define enum class includeBool { true, false}; and use it as a type of the 2nd argument.

[facebook-github-bot]

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@malfet merged this pull request in 0495180.