Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port cholesky_inverse to ATen #50269

Closed
wants to merge 50 commits into from
Closed

Port cholesky_inverse to ATen #50269

wants to merge 50 commits into from

Commits on Dec 21, 2020

  1. Ported cholesky_inverse to ATen; tests pass

    @IvanYashchuk
    IvanYashchuk committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    da9a254 View commit details
    Browse the repository at this point in the history

  2. Renamed self -> input

    @IvanYashchuk
    IvanYashchuk committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    3c95d86 View commit details
    Browse the repository at this point in the history

  3. Make _out variant to be the primary one 

    Use Tensor of ints for 'infos' instead of std::vector
    @IvanYashchuk
    IvanYashchuk committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    4486c37 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2021

  1. Merge remote-tracking branch 'upstream/master' into port-cholesky-inv… 

    …erse
    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    2afc8ec View commit details
    Browse the repository at this point in the history

  2. Corrected comments

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    c06c5a7 View commit details
    Browse the repository at this point in the history

  3. Added other dtypes to test_cholesky_inverse

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    b9da168 View commit details
    Browse the repository at this point in the history

  4. Use CPU, CUDA instead of DefaultBackend

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    39a7dbf View commit details
    Browse the repository at this point in the history

  5. Added path for batched cuda to use cholesky_solve

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    06f02e1 View commit details
    Browse the repository at this point in the history

  6. Moved cholesky_solve workaround to cholesky_inverse_out

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    d9bf828 View commit details
    Browse the repository at this point in the history

  7. Added missing .conj

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    84732f7 View commit details
    Browse the repository at this point in the history

  8. Fixed checking for cuda device

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    5cfdf52 View commit details
    Browse the repository at this point in the history

  9. Add missing upper to cholesky_solve_out call

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    69429c9 View commit details
    Browse the repository at this point in the history

  10. Fix lda argument for cholesky_solve

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    634f53f View commit details
    Browse the repository at this point in the history

  11. Updated tests

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    68de787 View commit details
    Browse the repository at this point in the history

  12. Removed unused import

    @IvanYashchuk
    IvanYashchuk committed Jan 7, 2021
    Configuration menu
    Copy the full SHA
    b7b482f View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2021

  1. Added op-based tests for cholesky_inverse

    @IvanYashchuk
    IvanYashchuk committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    747fd71 View commit details
    Browse the repository at this point in the history

  2. Use c10 full dispatcher

    @IvanYashchuk
    IvanYashchuk committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    78ef953 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into port-cholesky-inv… 

    …erse
    @IvanYashchuk
    IvanYashchuk committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    db1602c View commit details
    Browse the repository at this point in the history

  4. Allow non column major out

    @IvanYashchuk
    IvanYashchuk committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    f1ed1bc View commit details
    Browse the repository at this point in the history

  5. Fix mypy failure

    @IvanYashchuk
    IvanYashchuk committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    962a302 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. Changed AT_ERROR -> TORCH_CHECK; modified error message for batched 

    input
    @IvanYashchuk
    IvanYashchuk committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    962aef1 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. Moved conj_wrapper to header

    @IvanYashchuk
    IvanYashchuk committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    0ae5113 View commit details
    Browse the repository at this point in the history

  2. Added cpu kernel for matrix reflection and conjugation

    @IvanYashchuk
    IvanYashchuk committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    2641056 View commit details
    Browse the repository at this point in the history

  3. Added gpu kernel for matrix reflection and conjugation

    @IvanYashchuk
    IvanYashchuk committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    ab48313 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/master' into port-cholesky-inv… 

    …erse
    @IvanYashchuk
    IvanYashchuk committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    8011adb View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. Use DEFINE/DECLARE_DISPATCH for helper function instead of native_fun… 

    …ctions entry
    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    4ecd7c5 View commit details
    Browse the repository at this point in the history

  2. Added a comment why copy is needed

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    dd79d85 View commit details
    Browse the repository at this point in the history

  3. Use at::native::resize_output

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ae1acd1 View commit details
    Browse the repository at this point in the history

  4. Allocate infos with the required shape, don't use resize

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ec5e678 View commit details
    Browse the repository at this point in the history

  5. Fix comment

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ccf1440 View commit details
    Browse the repository at this point in the history

  6. Added comments on different code paths for out variant

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    cbe7e38 View commit details
    Browse the repository at this point in the history

  7. Removed cholesky_inverse test; it is replaced by OpInfo-based tests now

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e6b98cf View commit details
    Browse the repository at this point in the history

  8. Added an option to skip scripted jit

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    fc8c561 View commit details
    Browse the repository at this point in the history

  9. Added comment that infos must be on CPU for magma's single matrix cho… 

    …lesky inverse
    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    927298a View commit details
    Browse the repository at this point in the history

  10. Use batched cholesky_solve for single matrix cholesky_inverse because… 

    … it is much faster
    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    fded2b5 View commit details
    Browse the repository at this point in the history

  11. Specialized cuda kernel for symmetrization is not needed anymore

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    853f126 View commit details
    Browse the repository at this point in the history

  12. Removed magmaCholeskyInverse

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    9735cd9 View commit details
    Browse the repository at this point in the history

  13. Merge remote-tracking branch 'upstream/master' into port-cholesky-inv… 

    …erse
    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    494c912 View commit details
    Browse the repository at this point in the history

  14. Revert changes to UnaryComplexKernels

    @IvanYashchuk
    IvanYashchuk committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    aeba6d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. apply_cholesky_inverse support for batched inputs on CUDA using apply… 

    …_cholesky_solve
    @IvanYashchuk
    IvanYashchuk committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    edcb2f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2021

  1. Use test_complex_grad=False

    @IvanYashchuk
    IvanYashchuk committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    28e81bc View commit details
    Browse the repository at this point in the history

  2. Revert adding skipping scripted jit

    @IvanYashchuk
    IvanYashchuk committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    11bf2ec View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into port-cholesky-inv… 

    …erse
    @IvanYashchuk
    IvanYashchuk committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    a4b750a View commit details
    Browse the repository at this point in the history

  4. flake8

    @IvanYashchuk
    IvanYashchuk committed Jan 20, 2021
    Configuration menu
    Copy the full SHA
    081a206 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2021

  1. Merge branch 'master' into port-cholesky-inverse

    @IvanYashchuk
    IvanYashchuk committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    1dde747 View commit details
    Browse the repository at this point in the history

  2. Removed use_c10_dispatcher: full; it is now default

    @IvanYashchuk
    IvanYashchuk committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    a7bdecf View commit details
    Browse the repository at this point in the history

  3. Added check_batched_gradgrad=False

    @IvanYashchuk
    IvanYashchuk committed Jan 22, 2021
    Configuration menu
    Copy the full SHA
    703d490 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Updated the comment on infos' device

    @IvanYashchuk
    IvanYashchuk committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    3807d28 View commit details
    Browse the repository at this point in the history

  2. Added test case for non-invertible input

    @IvanYashchuk
    IvanYashchuk committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    682f80a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into port-cholesky-inv… 

    …erse
    @IvanYashchuk
    IvanYashchuk committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    f117e84 View commit details
    Browse the repository at this point in the history