-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add division overload with rounding_mode selection #50280
Closed
Closed
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c712bbc
Add division overload with rounding_mode selection
peterbell10 5e8b4a7
Update on "Add division overload with rounding_mode selection"
peterbell10 8bbfdfa
Update on "Add division overload with rounding_mode selection"
peterbell10 c582a55
Update on "Add division overload with rounding_mode selection"
peterbell10 6c6bda9
Update on "Add division overload with rounding_mode selection"
peterbell10 0687fe7
Update on "Add division overload with rounding_mode selection"
peterbell10 af02f1c
Update on "Add division overload with rounding_mode selection"
peterbell10 a838dd9
Update on "Add division overload with rounding_mode selection"
peterbell10 496cb93
Update on "Add division overload with rounding_mode selection"
peterbell10 c28ef0f
Update on "Add division overload with rounding_mode selection"
peterbell10 78f46ad
Update on "Add division overload with rounding_mode selection"
peterbell10 2617933
Update on "Add division overload with rounding_mode selection"
peterbell10 983d643
Update on "Add division overload with rounding_mode selection"
peterbell10 703e0b7
Update on "Add division overload with rounding_mode selection"
peterbell10 8784e96
Update on "Add division overload with rounding_mode selection"
peterbell10 2af43d7
Update on "Add division overload with rounding_mode selection"
peterbell10 69aac40
Update on "Add division overload with rounding_mode selection"
peterbell10 8529096
Update on "Add division overload with rounding_mode selection"
peterbell10 7e7b1d3
Update on "Add division overload with rounding_mode selection"
peterbell10 84f755f
Update on "Add division overload with rounding_mode selection"
peterbell10 61750ba
Update on "Add division overload with rounding_mode selection"
peterbell10 bb33706
Update on "Add division overload with rounding_mode selection"
peterbell10 6bd0e9f
Update on "Add division overload with rounding_mode selection"
peterbell10 0220e1c
Update on "Add division overload with rounding_mode selection"
peterbell10 2fcb3a5
Update on "Add division overload with rounding_mode selection"
peterbell10 71b0cfe
trial fix for mobile manifest issue
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rzou would you take a look here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mruberry I think you got the wrong user. Was that meant to be @zou3519?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was, thanks @peterbell10. Darn autocomplete!
cc @zou3519
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lgtm!