Assemble technical overview of FX #50291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit ec42c7a (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
ansley
pushed a commit
that referenced
this pull request
Jan 8, 2021
ghstack-source-id: f40d634a7b707fad9354ea107ead071eac6f2ec9 Pull Request resolved: #50291
jamesr66a
reviewed
Jan 8, 2021
[ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 9, 2021
ghstack-source-id: 30c31e8352b289eeef98eba7695eef1353569f4f Pull Request resolved: #50291
Codecov Report
@@ Coverage Diff @@
## gh/ansleyadelaide/29/base #50291 +/- ##
==========================================================
Coverage 80.69% 80.69%
==========================================================
Files 1902 1902
Lines 206335 206335
==========================================================
+ Hits 166494 166497 +3
+ Misses 39841 39838 -3 |
jamesr66a
reviewed
Jan 11, 2021
There was a problem hiding this comment.
Cool! There's some stuff duplicated form the fx/__init__.py docstring, like the description of the IR nodes. IMO we should deduplicate things and refer to that docstring as the single place this is described. This doc should be more focused on "below the cut" implementation details that are not in the public docstrings
[ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 12, 2021
ghstack-source-id: 6d8fd072830c59463feb77f79de1f35402af6164 Pull Request resolved: #50291
Differential Revision: [D25908444](https://our.internmc.facebook.com/intern/diff/D25908444) [ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 14, 2021
ghstack-source-id: 49863b79e4bdb900e289c5b162cd119e5c4daf6d Pull Request resolved: #50291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25908444