cleaned up ModuleAttributeError

[jonykarki]

Fixes #49726
Just cleaned up the unnecessary ModuleAttributeError

BC-breaking note:
ModuleAttributeError was added in the previous unsuccessful PR and removed here. If a user catches ModuleAttributeError specifically, this will no longer work. They should catch AttributeError instead.

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 43830fe (more details on the Dr. CI page):

---

• 5/5 failures possibly* introduced in this PR
  • 2/5 non-CircleCI failure(s)

---

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_xla_linux_bionic_py3_6_clang9_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in CMakeLists.txt
Auto-merging CMakeLists.txt
CONFLICT (add/add): Merge conflict in .jenkins/caffe2/test.sh
Auto-merging .jenkins/caffe2/test.sh
CONFLICT (add/add): Merge conflict in .flake8
Auto-merging .flake8
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py
Auto-merging .circleci/cimodel/data/dimensions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in CMakeLists.txt
Auto-merging CMakeLists.txt
CONFLICT (add/add): Merge conflict in .jenkins/caffe2/test.sh
Auto-merging .jenkins/caffe2/test.sh
CONFLICT (add/add): Merge conflict in .flake8
Auto-merging .flake8
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py
Auto-merging .circleci/cimodel/data/dimensions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

pytorch_linux_xenial_py3_6_gcc5_4_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.

CONFLICT (add/add): Merge conflict in CMakeLists.txt
Auto-merging CMakeLists.txt
CONFLICT (add/add): Merge conflict in .jenkins/caffe2/test.sh
Auto-merging .jenkins/caffe2/test.sh
CONFLICT (add/add): Merge conflict in .flake8
Auto-merging .flake8
CONFLICT (add/add): Merge conflict in .circleci/config.yml
Auto-merging .circleci/config.yml
CONFLICT (add/add): Merge conflict in .circleci/cimodel/data/dimensions.py
Auto-merging .circleci/cimodel/data/dimensions.py
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

---

ci.pytorch.org: 1 failed

• Failed: pr/pytorch-linux-bionic-rocm3.10-py3.6

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

[codecov]

Codecov Report

Merging #50298 (0348901) into master (aa18d17) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #50298   +/-   ##
=======================================
  Coverage   80.68%   80.69%           
=======================================
  Files        1904     1904           
  Lines      206555   206554    -1     
=======================================
+ Hits       166667   166671    +4     
+ Misses      39888    39883    -5     

[jbschlosser]

Looks great- thanks for submitting this! Just one minor thing regarding the test that was added in the previous PR.

[jbschlosser]

LGTM! Looks like a rebase should fix the remaining failing checks.

[facebook-github-bot]

@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@jbschlosser merged this pull request in 934805b.