Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Calculate strides for metal tensors #50309

Closed
wants to merge 2 commits into from
Closed

Conversation

xta0
Copy link
Contributor

@xta0 xta0 commented Jan 9, 2021

Stack from ghstack:

Previously, in order to unblock the dogfooding, we did some hacks to calculate the strides for the output tensor. Now it's time to fix that.

Differential Revision: D25821766

Previously, in order to unblock the dogfooding, we did some hacks to calculate the strides for the output tensor. Now it's time to fix that.

Differential Revision: [D25821766](https://our.internmc.facebook.com/intern/diff/D25821766/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 9, 2021

💊 CI failures summary and remediations

As of commit 63e740f (more details on the Dr. CI page):


  • 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (1/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
Auto-merging test/backward_compatibility/check_backward_compatibility.py
Auto-merging mypy.ini
Auto-merging aten/src/ATen/native/vulkan/ops/Pool.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Pool.cpp
Auto-merging aten/src/ATen/native/vulkan/ops/Mm.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Mm.cpp
Auto-merging aten/src/ATen/native/vulkan/ops/Convolution.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Convolution.cpp
Auto-merging aten/src/ATen/native/native_functions.yaml
Auto-merging aten/src/ATen/core/ivalue_inl.h
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_build (2/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
Auto-merging test/backward_compatibility/check_backward_compatibility.py
Auto-merging mypy.ini
Auto-merging aten/src/ATen/native/vulkan/ops/Pool.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Pool.cpp
Auto-merging aten/src/ATen/native/vulkan/ops/Mm.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Mm.cpp
Auto-merging aten/src/ATen/native/vulkan/ops/Convolution.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Convolution.cpp
Auto-merging aten/src/ATen/native/native_functions.yaml
Auto-merging aten/src/ATen/core/ivalue_inl.h
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1

See CircleCI build pytorch_linux_xenial_cuda9_2_cudnn7_py3_gcc5_4_build (3/3)

Step: "(Optional) Merge target branch" (full log | diagnosis details | 🔁 rerun)

Automatic merge failed; fix conflicts and then commit the result.
Auto-merging test/backward_compatibility/check_backward_compatibility.py
Auto-merging mypy.ini
Auto-merging aten/src/ATen/native/vulkan/ops/Pool.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Pool.cpp
Auto-merging aten/src/ATen/native/vulkan/ops/Mm.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Mm.cpp
Auto-merging aten/src/ATen/native/vulkan/ops/Convolution.cpp
CONFLICT (content): Merge conflict in aten/src/ATen/native/vulkan/ops/Convolution.cpp
Auto-merging aten/src/ATen/native/native_functions.yaml
Auto-merging aten/src/ATen/core/ivalue_inl.h
Automatic merge failed; fix conflicts and then commit the result.


Exited with code exit status 1


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 8 times.

Previously, in order to unblock the dogfooding, we did some hacks to calculate the strides for the output tensor. Now it's time to fix that.

Differential Revision: [D25821766](https://our.internmc.facebook.com/intern/diff/D25821766/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in ba83aea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants