Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range assert in autograd engine queue lookup #50372

Closed

Conversation

albanD
Copy link
Collaborator

@albanD albanD commented Jan 11, 2021

Follow up to #49652

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 11, 2021

💊 CI failures summary and remediations

As of commit f4f444e (more details on the Dr. CI page):


  • 2/2 failures possibly* introduced in this PR
    • 2/2 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This comment has been revised 6 times.

@albanD albanD force-pushed the add_range_assert_autograd_engine branch from a84f686 to f4f444e Compare January 11, 2021 14:30
@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #50372 (f4f444e) into master (9d8bd21) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #50372      +/-   ##
==========================================
- Coverage   80.70%   80.70%   -0.01%     
==========================================
  Files        1904     1904              
  Lines      206596   206597       +1     
==========================================
- Hits       166742   166737       -5     
- Misses      39854    39860       +6     

Copy link
Collaborator

@jeffdaily jeffdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding the assert.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@albanD merged this pull request in e160362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants