Add complex support for torch.{acosh, asinh, atanh}
#50387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
anjali411
changed the title
torch.{cosh, sinh, tanh}
anjali411
added
complex_autograd
module: complex
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Jan 11, 2021
ghstack-source-id: 5b80363d49813698688e378d2d2ef9a284f11739 Pull Request resolved: #50387
mruberry
reviewed
Jan 12, 2021
test/test_torch.py
Outdated
| ('acosh', '', lambda t, d: _small_3d(t, d) + 1, lambda t, d: [], 1e-3, 1e-2, 1e-5, torch.testing.get_all_fp_dtypes()), | ||
| ('asinh', '', _small_3d, lambda t, d: [], 1e-3, 1e-2, 1e-5, torch.testing.get_all_fp_dtypes()), | ||
| ('atanh', '', _small_3d, lambda t, d: [], 1e-3, 1e-2, 1e-5, torch.testing.get_all_fp_dtypes()), | ||
| ('acosh', '', lambda t, d: _small_3d(t, d) + 1, lambda t, d: [], 1e-3, 1e-2, 1e-5, |
There was a problem hiding this comment.
These were recently removed (they're redundant with the OpInfo tests). You can just revert changes to test_torch.py for this PR.
mruberry
reviewed
Jan 12, 2021
| @@ -336,23 +336,23 @@ static void cosh_kernel(TensorIterator& iter) { | |||
| } | |||
|
|
|||
| static void acosh_kernel(TensorIterator& iter) { | |||
There was a problem hiding this comment.
CUDA dispatches also need an update.
mruberry
reviewed
Jan 12, 2021
anjali411
changed the title
torch.{cosh, sinh, tanh}torch.{acosh, asinh, atanh}
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Jan 15, 2021
ghstack-source-id: fe59a5244e702853f1e372c935a0b1bd9486bd30 Pull Request resolved: #50387
[ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Jan 17, 2021
ghstack-source-id: dac14477cb366ff0ea3a7953ec3a1a1879e902c6 Pull Request resolved: #50387
|
Looks like this will have to skip test_fn_grad_acosh_cuda_complex128 - TestGradientsCUDA on pytorch_windows_vs2019_py36_cuda10.1_test2, too. I'm not totally sure what's going on there. |
mruberry
approved these changes
Jan 18, 2021
[ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/anjali411/81/base #50387 +/- ##
=====================================================
Coverage 80.66% 80.66%
=====================================================
Files 1913 1913
Lines 208091 208091
=====================================================
+ Hits 167849 167854 +5
+ Misses 40242 40237 -5 |
Differential Revision: [D25947496](https://our.internmc.facebook.com/intern/diff/D25947496) [ghstack-poisoned]
anjali411
added a commit
that referenced
this pull request
Jan 19, 2021
ghstack-source-id: 9235bedd932e31e10a8c70f6c3fe132fab6ae069 Pull Request resolved: #50387
|
@anjali411 merged this pull request in 5d64658. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
torch.{acosh, asinh, atanh}#50387 Add complex support fortorch.{acosh, asinh, atanh}Differential Revision: D25947496