[PyTorch] Make SROpFunctor a raw function pointer #50395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no need for these to be `std::function`. Differential Revision: [D25874187](https://our.internmc.facebook.com/intern/diff/D25874187/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 3fafbc0 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. This comment has been revised 3 times. |
facebook-github-bot
added
the
oncall: jit
swolchok
added a commit
that referenced
this pull request
Jan 11, 2021
There's no need for these to be `std::function`. Differential Revision: [D25874187](https://our.internmc.facebook.com/intern/diff/D25874187/) ghstack-source-id: 119684828 Pull Request resolved: #50395
|
This pull request has been merged in c6cb632. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
There's no need for these to be
std::function.Differential Revision: D25874187