Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quant][doc] Adding a table comparing eager and fx graph mode #50413

Closed
wants to merge 10 commits into from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jan 12, 2021

Stack from ghstack:

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D25886960

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 12, 2021

💊 CI failures summary and remediations

As of commit a8cb58d (more details on the Dr. CI page):



❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jan 14 05:25:50 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 05:25:50                        ~~~~ <--- HERE
Jan 14 05:25:50 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 05:25:50 
Jan 14 05:25:50 
Jan 14 05:25:50 ======================================================================
Jan 14 05:25:50 ERROR [0.203s]: test_where_and_typing (__main__.TestTEFuser)
Jan 14 05:25:50 ----------------------------------------------------------------------
Jan 14 05:25:50 Traceback (most recent call last):
Jan 14 05:25:50   File "test_jit_fuser_te.py", line 1142, in test_where_and_typing
Jan 14 05:25:50     x = torch.randn(4, 4, dtype=torch.double, device=device)
Jan 14 05:25:50 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 05:25:50 
Jan 14 05:25:50 ======================================================================
Jan 14 05:25:50 ERROR [0.174s]: test_zero_element_tensors_cuda (__main__.TestTEFuser)
Jan 14 05:25:50 ----------------------------------------------------------------------
Jan 14 05:25:50 Traceback (most recent call last):
Jan 14 05:25:50   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 888, in wrapper
Jan 14 05:25:50     method(*args, **kwargs)
Jan 14 05:25:50   File "test_jit_fuser_te.py", line 178, in test_zero_element_tensors_cuda
Jan 14 05:25:50     self._test_zero_element_tensors(device="cuda")
Jan 14 05:25:50   File "test_jit_fuser_te.py", line 174, in _test_zero_element_tensors

ci.pytorch.org: 1 failed


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

jerryzh168 added a commit that referenced this pull request Jan 12, 2021
Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 783417cfa57f4a3807534bc7fa5c968ce6a0665f
Pull Request resolved: #50413
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 12, 2021
Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 84a8cf74f5fa23b19b4e73a21574a3b326fa3149
Pull Request resolved: #50413
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 14, 2021
Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c8ac735bb52fdaea36029df8f8ae09ad05e22c14
Pull Request resolved: #50413
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 15, 2021
Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6d3072cc422820b80fea7ba0279e616861c91e37
Pull Request resolved: #50413
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 20, 2021
Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: b644c77bfab9b6eef200227365e5672486b36066
Pull Request resolved: #50413
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 20, 2021
Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: d0fa5281f0a08677db4469b4722d396e73159a5e
Pull Request resolved: #50413
Copy link
Contributor

@vkuzo vkuzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

docs/source/quantization.rst Outdated Show resolved Hide resolved
docs/source/quantization.rst Outdated Show resolved Hide resolved
docs/source/quantization.rst Show resolved Hide resolved
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
…ode"

Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D25886960](https://our.internmc.facebook.com/intern/diff/D25886960)

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request Jan 21, 2021
Summary:

Test Plan:
.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 979c0ab5fa8cd04f8736e43595862b523dd7b85e
Pull Request resolved: #50413
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #50413 (4d617f0) into gh/jerryzh168/530/base (7fdc6a2) will increase coverage by 5.02%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##           gh/jerryzh168/530/base   #50413      +/-   ##
==========================================================
+ Coverage                   75.65%   80.68%   +5.02%     
==========================================================
  Files                        1916     1916              
  Lines                      209287   209287              
==========================================================
+ Hits                       158343   168854   +10511     
+ Misses                      50944    40433   -10511     

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b5242d6.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/530/head branch January 25, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants