[quant] update embedding module to not store qweight

[supriyar]

Stack from ghstack:

• [quant] update embedding module to not store qweight #50418 [quant] update embedding module to not store qweight

Summary:
previously we were storing the quantized weight as a module attribute, which
was resulting in the weight getting stored as part of the model and getting stored twice (once as qweight and other as unpacked_weight)
We don't need this since we already store the unpacked weights as part of the model.

Test Plan:
Before

Archive:  tmp.pt
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
     586  Stored      586   0% 00-00-1980 00:00 5fefdda0  tmp/extra/producer_info.json
 1588700  Stored  1588700   0% 00-00-1980 00:00 04e0da4c  tmp/data/0
   63548  Stored    63548   0% 00-00-1980 00:00 0ceb1f45  tmp/data/1
   63548  Stored    63548   0% 00-00-1980 00:00 517bc3ab  tmp/data/2
 1588700  Stored  1588700   0% 00-00-1980 00:00 dbe88c73  tmp/data/3
   63548  Stored    63548   0% 00-00-1980 00:00 d8dc47c4  tmp/data/4
   63548  Stored    63548   0% 00-00-1980 00:00 b9e0c20f  tmp/data/5
    1071  Stored     1071   0% 00-00-1980 00:00 10dc9350  tmp/data.pkl
     327  Defl:N      203  38% 00-00-1980 00:00 dfddb661  tmp/code/__torch__/___torch_mangle_0.py
     185  Stored      185   0% 00-00-1980 00:00 308f580b  tmp/code/__torch__/___torch_mangle_0.py.debug_pkl
    1730  Defl:N      515  70% 00-00-1980 00:00 aa11f799  tmp/code/__torch__/torch/nn/quantized/modules/embedding_ops.py
    1468  Defl:N      636  57% 00-00-1980 00:00 779609a6  tmp/code/__torch__/torch/nn/quantized/modules/embedding_ops.py.debug_pkl
       0  Stored        0   0% 00-00-1980 00:00 00000000  tmp/code/__torch__/torch/classes/quantized.py
       6  Stored        6   0% 00-00-1980 00:00 816d0907  tmp/code/__torch__/torch/classes/quantized.py.debug_pkl
       4  Stored        4   0% 00-00-1980 00:00 57092f6d  tmp/constants.pkl
       2  Stored        2   0% 00-00-1980 00:00 55679ed1  tmp/version
--------          -------  ---                            -------
 3436971          3434800   0%                            16 files

After

Archive:  tmp.pt
 Length   Method    Size  Cmpr    Date    Time   CRC-32   Name
--------  ------  ------- ---- ---------- ----- --------  ----
 1588700  Stored  1588700   0% 00-00-1980 00:00 a4da6981  tmp/data/0
   63548  Stored    63548   0% 00-00-1980 00:00 74d9b607  tmp/data/1
   63548  Stored    63548   0% 00-00-1980 00:00 e346a0c2  tmp/data/2
     952  Stored      952   0% 00-00-1980 00:00 eff8706e  tmp/data.pkl
     375  Defl:N      227  40% 00-00-1980 00:00 96c77b68  tmp/code/__torch__/quantization/test_quantize/___torch_mangle_23.py
     228  Defl:N      162  29% 00-00-1980 00:00 6a378113  tmp/code/__torch__/quantization/test_quantize/___torch_mangle_23.py.debug_pkl
    1711  Defl:N      509  70% 00-00-1980 00:00 66d8fd61  tmp/code/__torch__/torch/nn/quantized/modules/embedding_ops.py
    1473  Defl:N      634  57% 00-00-1980 00:00 beb2323b  tmp/code/__torch__/torch/nn/quantized/modules/embedding_ops.py.debug_pkl
       0  Stored        0   0% 00-00-1980 00:00 00000000  tmp/code/__torch__/torch/classes/quantized.py
       6  Stored        6   0% 00-00-1980 00:00 816d0907  tmp/code/__torch__/torch/classes/quantized.py.debug_pkl
       4  Stored        4   0% 00-00-1980 00:00 57092f6d  tmp/constants.pkl
       2  Stored        2   0% 00-00-1980 00:00 55679ed1  tmp/version
--------          -------  ---                            -------
 1720547          1718292   0%                            12 files

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D25879879

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 2b0b33a (more details on the Dr. CI page):

---

• 2/3 failures possibly* introduced in this PR
  • 2/2 non-CircleCI failure(s)
• 1/3 tentatively recognized as flaky ❄️
  • Click here to rerun these jobs

---

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jan 14 04:56:56 RuntimeError: CUDA error: an illegal memory access was encountered

Jan 14 04:56:56                        ~~~~ <--- HERE
Jan 14 04:56:56 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 04:56:56 
Jan 14 04:56:56 
Jan 14 04:56:56 ======================================================================
Jan 14 04:56:56 ERROR [0.205s]: test_where_and_typing (__main__.TestTEFuser)
Jan 14 04:56:56 ----------------------------------------------------------------------
Jan 14 04:56:56 Traceback (most recent call last):
Jan 14 04:56:56   File "test_jit_fuser_te.py", line 1142, in test_where_and_typing
Jan 14 04:56:56     x = torch.randn(4, 4, dtype=torch.double, device=device)
Jan 14 04:56:56 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 04:56:56 
Jan 14 04:56:56 ======================================================================
Jan 14 04:56:56 ERROR [0.176s]: test_zero_element_tensors_cuda (__main__.TestTEFuser)
Jan 14 04:56:56 ----------------------------------------------------------------------
Jan 14 04:56:56 Traceback (most recent call last):
Jan 14 04:56:56   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 888, in wrapper
Jan 14 04:56:56     method(*args, **kwargs)
Jan 14 04:56:56   File "test_jit_fuser_te.py", line 178, in test_zero_element_tensors_cuda
Jan 14 04:56:56     self._test_zero_element_tensors(device="cuda")
Jan 14 04:56:56   File "test_jit_fuser_te.py", line 174, in _test_zero_element_tensors

---

ci.pytorch.org: 1 failed

• Failed: pr/pytorch-linux-bionic-rocm3.10-py3.6

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

[z-a-f]

lgtm

[facebook-github-bot]

This pull request has been merged in 554a1a7.