Add torch.cuda.can_device_access_peer #50446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And unrelying torch._C._cuda_canDeviceAccessPeer, which is a wrapper around cudaDeviceCanAccessPeer
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 0e744bc (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
mrshenli
approved these changes
Jan 12, 2021
| @@ -305,6 +305,18 @@ def get_device_properties(device: _device_t) -> _CudaDeviceProperties: | |||
| raise AssertionError("Invalid device id") | |||
| return _get_device_properties(device) # type: ignore[name-defined] | |||
|
|
|||
| def can_device_access_peer(device: _device_t, peer_device: _device_t) -> bool: | |||
| r"""Checks if peer access between two devices is possible. | |||
There was a problem hiding this comment.
do we need to mention that if device == -1, it will use the current device?
Codecov Report
@@ Coverage Diff @@
## master #50446 +/- ##
==========================================
- Coverage 80.70% 80.70% -0.01%
==========================================
Files 1904 1904
Lines 206597 206606 +9
==========================================
+ Hits 166742 166746 +4
- Misses 39855 39860 +5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And unrelying torch._C._cuda_canDeviceAccessPeer, which is a wrapper around cudaDeviceCanAccessPeer