Validate args in HalfCauchy and HalfNormal

[fritzo]

Fixes #50404
Complementary to #50403

This also fixes HalfCauchy.cdf(), HalfNormal.log_prob(), HalfNormal.cdf() and ensures validation is not done twice.

cc @feynmanliang

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 814f833 (more details on the Dr. CI page):

---

• 2/3 failures possibly* introduced in this PR
  • 2/2 non-CircleCI failure(s)
• 1/3 tentatively recognized as flaky ❄️
  • Click here to rerun these jobs

---

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

Jan 14 11:26:04 RuntimeError: CUDA error: an illegal memory access was encountered

Jan 14 11:26:04                        ~~~~ <--- HERE
Jan 14 11:26:04 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 11:26:04 
Jan 14 11:26:04 
Jan 14 11:26:04 ======================================================================
Jan 14 11:26:04 ERROR [0.203s]: test_where_and_typing (__main__.TestTEFuser)
Jan 14 11:26:04 ----------------------------------------------------------------------
Jan 14 11:26:04 Traceback (most recent call last):
Jan 14 11:26:04   File "test_jit_fuser_te.py", line 1142, in test_where_and_typing
Jan 14 11:26:04     x = torch.randn(4, 4, dtype=torch.double, device=device)
Jan 14 11:26:04 RuntimeError: CUDA error: an illegal memory access was encountered
Jan 14 11:26:04 
Jan 14 11:26:04 ======================================================================
Jan 14 11:26:04 ERROR [0.178s]: test_zero_element_tensors_cuda (__main__.TestTEFuser)
Jan 14 11:26:04 ----------------------------------------------------------------------
Jan 14 11:26:04 Traceback (most recent call last):
Jan 14 11:26:04   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 888, in wrapper
Jan 14 11:26:04     method(*args, **kwargs)
Jan 14 11:26:04   File "test_jit_fuser_te.py", line 178, in test_zero_element_tensors_cuda
Jan 14 11:26:04     self._test_zero_element_tensors(device="cuda")
Jan 14 11:26:04   File "test_jit_fuser_te.py", line 174, in _test_zero_element_tensors

---

ci.pytorch.org: 1 failed

• Failed: pr/pytorch-linux-bionic-rocm3.10-py3.6

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

[neerajprad]

I think the test should be fixed by #50403, so I'll merge this after.

[neerajprad]

@fritzo - could you merge and push again? That should fix the failing tests.

[facebook-github-bot]

@neerajprad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@neerajprad merged this pull request in 3dcf126.