Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.circleci: Set +u for all conda install commands #50505

Closed
wants to merge 4 commits into from

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Jan 13, 2021

Stack from ghstack:

Even with +u set for the the conda install it still seems to fail out
with an unbound variable error. Let's try and give it a default value
instead.

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Differential Revision: D25913692

Even with +u set for the the conda install it still seems to fail out
with an unbound variable error. Let's try and give it a default value
instead.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 13, 2021

💊 CI failures summary and remediations

As of commit 4c038fd (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Even with +u set for the the conda install it still seems to fail out
with an unbound variable error. Let's try and give it a default value
instead.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@seemethere seemethere changed the title .circleci: Attempt to set default value for unbound var .circleci: Set +u for all conda install commands Jan 14, 2021
@seemethere seemethere requested a review from a team January 14, 2021 17:16
@seemethere seemethere added module: ci Related to continuous integration oncall: releng In support of CI and Release Engineering labels Jan 14, 2021
Copy link
Contributor

@walterddr walterddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to include tensorpipe upgrade?

Even with +u set for the the conda install it still seems to fail out
with an unbound variable error. Let's try and give it a default value
instead.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
Even with +u set for the the conda install it still seems to fail out
with an unbound variable error. Let's try and give it a default value
instead.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@seemethere
Copy link
Member Author

Did you intend to include tensorpipe upgrade?

tensorpipe update has been removed

@seemethere seemethere requested a review from a team January 14, 2021 18:18
@facebook-github-bot
Copy link
Contributor

@seemethere merged this pull request in 296e4a0.

@facebook-github-bot facebook-github-bot deleted the gh/seemethere/48/head branch January 19, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged module: ci Related to continuous integration oncall: releng In support of CI and Release Engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants