Fix replication_pad for cuda launch configuration #50565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngimel
reviewed
Jan 15, 2021
| auto devOutput = output_.packed_accessor64<scalar_t, 3>(); | ||
|
|
||
| int outputPlaneSize = devOutput.size(2); | ||
| int size1 = devOutput.size(1); |
| int size1 = devOutput.size(1); | ||
| int size0 = devOutput.size(0); | ||
|
|
||
| int y_left = size1; |
There was a problem hiding this comment.
for (int64_t block_y=0; block_y < size1; block_y += 65535){
auto block_y_size = std::min(size1-block_y, 65535);
for (int64_t block_z=0; block_z < size0; block_z += 65535) {
auto block_z_size = std::min(size0-block_z, 65535);
dim3 gridSize(THCCeilDiv(outputPlaneSize, 256), block_y_size, block_z_size);
dim3 blockSize(...);
launch_kernel(...., block_y, block_z);
}
}
is a bit simpler
Codecov Report
@@ Coverage Diff @@
## master #50565 +/- ##
==========================================
+ Coverage 80.65% 80.67% +0.01%
==========================================
Files 1913 1910 -3
Lines 208151 207864 -287
==========================================
- Hits 167887 167696 -191
+ Misses 40264 40168 -96 |
|
cc @ptrblck |
xwang233
changed the title
ngimel
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #49601