[ONNX] Add logical_and, logical_or, logical_xor torch op support in pytorch exporter #50570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwangdeyu
changed the title
jiafatom
reviewed
Jan 15, 2021
There was a problem hiding this comment.
There is build error in one of the UTs, please fix, thanks.
Jan 15 05:35:02 Coverage XML written to file test/coverage.xml
Jan 15 05:35:02
Jan 15 05:35:02 =========================== short test summary info ============================
Jan 15 05:35:02 FAILED test/onnx/test_pytorch_onnx_onnxruntime.py::TestONNXRuntime::test_logical_xor
Jan 15 05:35:02 ==== 1 failed, 1091 passed, 882 skipped, 1686 warnings in 939.26s (0:15:39) ====
hwangdeyu
force-pushed
the
deyu/logical_and_or
branch
from
a33e7ef
to
e37ac33
Compare
Thanks! will check the failure reason. |
BowenBao
added a commit
that referenced
this pull request
Jan 21, 2021
…ytorch exporter (#50570) Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. [ghstack-poisoned]
This was referenced Jan 21, 2021
[ONNX] Add logical_and, logical_or, logical_xor torch op support in pytorch exporter (#50570)
#50909
Closed
BowenBao
added a commit
that referenced
this pull request
Jan 21, 2021
…upport in pytorch exporter (#50570)" Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 22, 2021
…upport in pytorch exporter (#50570)" Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. [ghstack-poisoned]
This was referenced Jan 22, 2021
BowenBao
added a commit
that referenced
this pull request
Jan 22, 2021
…upport in pytorch exporter (#50570)" Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. Differential Revision: [D26023933](https://our.internmc.facebook.com/intern/diff/D26023933) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 25, 2021
…upport in pytorch exporter (#50570)" Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 25, 2021
…upport in pytorch exporter (#50570)" Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. Differential Revision: [D26050884](https://our.internmc.facebook.com/intern/diff/D26050884) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 26, 2021
…upport in pytorch exporter (#50570)" Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. Differential Revision: [D26050884](https://our.internmc.facebook.com/intern/diff/D26050884) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 28, 2021
…ytorch exporter (#50570) (#50909) Summary: Pull Request resolved: #50909 Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. Test Plan: Imported from OSS Reviewed By: pbelevich Differential Revision: D26050884 Pulled By: SplitInfinity fbshipit-source-id: 2db564e9726c18a3477f9268a0ff862cd2c40e4d
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 28, 2021
…ytorch exporter (pytorch#50570) Fixes #{} Add logical_and, logical_or, logical_xor torch op support in pytorch exporter. ghstack-source-id: 0532c7aead8109aeac854e67135a98d1ef467ec1 Pull Request resolved: pytorch#50909
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #{}
Add logical_and, logical_or, logical_xor torch op support in pytorch exporter.