Document example of Proxy use #50583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 15, 2021
ghstack-source-id: 4bdbd9781c194f75e707be90cd3dbd2c94779719 Pull Request resolved: #50583
[ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 15, 2021
ghstack-source-id: 763f7dd09ebae474e84805be54dc3bd2280aa8db Pull Request resolved: #50583
jamesr66a
reviewed
Jan 15, 2021
There was a problem hiding this comment.
Looks good, though I think this emphasizes a "boundary case" I guess I would call it, where you're tracing an entire function. It might be good to show also show using Proxy's to inline a given function into another function, or to show using Proxies within some metaprogramming code to emit operations (i.e. not just tracing through straightline code)
[ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 21, 2021
ghstack-source-id: 66a8c17645b9ae3e1be91c933691f8614d1b8738 Pull Request resolved: #50583
jamesr66a
approved these changes
Jan 22, 2021
[ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 22, 2021
ghstack-source-id: c25e0d3300ca648892fa3964cc8c486a516df0c2 Pull Request resolved: #50583
Differential Revision: [D26010501](https://our.internmc.facebook.com/intern/diff/D26010501) [ghstack-poisoned]
ansley
pushed a commit
that referenced
this pull request
Jan 22, 2021
ghstack-source-id: 278e7e57194e81464785334f08d7db8c44264f1e Pull Request resolved: #50583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D26010501