[Collective APIs] Make python object collective API args consistent #50625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make API signatures consistent and provide default argument similar to the tensor collectives. Differential Revision: [D25932012](https://our.internmc.facebook.com/intern/diff/D25932012/) [ghstack-poisoned]
rohan-varma
requested review from
mingzhe09088,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
…onsistent" Make API signatures consistent and provide default argument similar to the tensor collectives. Differential Revision: [D25932012](https://our.internmc.facebook.com/intern/diff/D25932012/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Jan 15, 2021
Pull Request resolved: #50625 Make API signatures consistent and provide default argument similar to the tensor collectives. ghstack-source-id: 119894882 Differential Revision: [D25932012](https://our.internmc.facebook.com/intern/diff/D25932012/)
…onsistent" Make API signatures consistent and provide default argument similar to the tensor collectives. Differential Revision: [D25932012](https://our.internmc.facebook.com/intern/diff/D25932012/) [ghstack-poisoned]
rohan-varma
changed the title
rohan-varma
changed the title
wanchaol
approved these changes
Jan 30, 2021
…onsistent" Make API signatures consistent and provide default argument similar to the tensor collectives. Differential Revision: [D25932012](https://our.internmc.facebook.com/intern/diff/D25932012/) [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/rohan-varma/217/base #50625 +/- ##
===========================================================
- Coverage 80.85% 80.85% -0.01%
===========================================================
Files 1938 1938
Lines 211215 211215
===========================================================
- Hits 170782 170771 -11
- Misses 40433 40444 +11 |
|
This pull request has been merged in c255628. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Make API signatures consistent and provide default argument similar to
the tensor collectives.
Differential Revision: D25932012