Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIT] Fix archive file extension in examples and docs #50649

Closed

Conversation

SplitInfinity
Copy link

@SplitInfinity SplitInfinity commented Jan 16, 2021

Stack from ghstack:

Summary
Tutorials, documentation and comments are not consistent with the file
extension they use for JIT archives. This commit modifies certain
instances of *.pth in torch.jit.save calls with *.pt.

Test Plan
Continuous integration.

Fixes
This commit fixes #49660.

Differential Revision: D25961628

**Summary**
Tutorials, documentation and comments are not consistent with the file
extension they use for JIT archives. This commit modifies certain
instances of `*.pth` in `torch.jit.save` calls with `*.pt`.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #49660.

[ghstack-poisoned]
@facebook-github-bot facebook-github-bot added cla signed oncall: jit Add this issue/PR to JIT oncall triage queue labels Jan 16, 2021
SplitInfinity pushed a commit that referenced this pull request Jan 16, 2021
**Summary**
Tutorials, documentation and comments are not consistent with the file
extension they use for JIT archives. This commit modifies certain
instances of `*.pth` in `torch.jit.save` calls with `*.pt`.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #49660.

ghstack-source-id: df89aa3c406c46ed657f5ceec033092a7f66b21c
Pull Request resolved: #50649
Copy link
Contributor

@Lilyjjo Lilyjjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✍️ 🚀

**Summary**
Tutorials, documentation and comments are not consistent with the file
extension they use for JIT archives. This commit modifies certain
instances of `*.pth` in `torch.jit.save` calls with `*.pt`.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #49660.

[ghstack-poisoned]
SplitInfinity pushed a commit that referenced this pull request Jan 19, 2021
**Summary**
Tutorials, documentation and comments are not consistent with the file
extension they use for JIT archives. This commit modifies certain
instances of `*.pth` in `torch.jit.save` calls with `*.pt`.

**Test Plan**
Continuous integration.

**Fixes**
This commit fixes #49660.

ghstack-source-id: a06575145c90c0b303d49d0450095684ade4ba66
Pull Request resolved: #50649
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #50649 (506767d) into gh/splitinfinity/92/base (0503656) will increase coverage by 0.00%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##           gh/splitinfinity/92/base   #50649   +/-   ##
=========================================================
  Coverage                     80.64%   80.65%           
=========================================================
  Files                          1913     1913           
  Lines                        208150   208150           
=========================================================
+ Hits                         167872   167884   +12     
+ Misses                        40278    40266   -12     

@facebook-github-bot
Copy link
Contributor

@SplitInfinity merged this pull request in 4aea007.

@facebook-github-bot facebook-github-bot deleted the gh/splitinfinity/92/head branch January 23, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed Merged oncall: jit Add this issue/PR to JIT oncall triage queue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants