New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JIT] Fix archive file extension in examples and docs #50649
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Tutorials, documentation and comments are not consistent with the file extension they use for JIT archives. This commit modifies certain instances of `*.pth` in `torch.jit.save` calls with `*.pt`. **Test Plan** Continuous integration. **Fixes** This commit fixes #49660. [ghstack-poisoned]
facebook-github-bot
added
cla signed
oncall: jit
Add this issue/PR to JIT oncall triage queue
labels
Jan 16, 2021
SplitInfinity
pushed a commit
that referenced
this pull request
Jan 16, 2021
**Summary** Tutorials, documentation and comments are not consistent with the file extension they use for JIT archives. This commit modifies certain instances of `*.pth` in `torch.jit.save` calls with `*.pt`. **Test Plan** Continuous integration. **Fixes** This commit fixes #49660. ghstack-source-id: df89aa3c406c46ed657f5ceec033092a7f66b21c Pull Request resolved: #50649
Lilyjjo
approved these changes
Jan 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✍️ 🚀
**Summary** Tutorials, documentation and comments are not consistent with the file extension they use for JIT archives. This commit modifies certain instances of `*.pth` in `torch.jit.save` calls with `*.pt`. **Test Plan** Continuous integration. **Fixes** This commit fixes #49660. [ghstack-poisoned]
SplitInfinity
pushed a commit
that referenced
this pull request
Jan 19, 2021
**Summary** Tutorials, documentation and comments are not consistent with the file extension they use for JIT archives. This commit modifies certain instances of `*.pth` in `torch.jit.save` calls with `*.pt`. **Test Plan** Continuous integration. **Fixes** This commit fixes #49660. ghstack-source-id: a06575145c90c0b303d49d0450095684ade4ba66 Pull Request resolved: #50649
Codecov Report
@@ Coverage Diff @@
## gh/splitinfinity/92/base #50649 +/- ##
=========================================================
Coverage 80.64% 80.65%
=========================================================
Files 1913 1913
Lines 208150 208150
=========================================================
+ Hits 167872 167884 +12
+ Misses 40278 40266 -12 |
@SplitInfinity merged this pull request in 4aea007. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
Tutorials, documentation and comments are not consistent with the file
extension they use for JIT archives. This commit modifies certain
instances of
*.pth
intorch.jit.save
calls with*.pt
.Test Plan
Continuous integration.
Fixes
This commit fixes #49660.
Differential Revision: D25961628