Enable TensorPipe CUDA fallback channel #50675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
mrshenli
requested review from
mingzhe09088,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
This was referenced Jan 18, 2021
facebook-github-bot
added
cla signed
oncall: distributed
beauby
approved these changes
Jan 18, 2021
lw
reviewed
Jan 18, 2021
| @@ -86,6 +86,8 @@ constexpr int64_t kBasicChannelPriority = 0; | |||
| #if TENSORPIPE_HAS_CUDA_IPC_CHANNEL && defined(USE_CUDA_NOT_ROCM) | |||
| constexpr int64_t kCudaIpcChannelPriority = 300; | |||
| constexpr int64_t kCudaXthChannelPriority = 400; | |||
| constexpr int64_t kCudaBasicChannelPriority = 500; | |||
There was a problem hiding this comment.
Same here, shouldn't be guarded by TENSORPIPE_HAS_CUDA_IPC_CHANNEL.
There was a problem hiding this comment.
Oh and actually this should have a much lower priority, like 100. Otherwise we'll always prefer sending over TCP rather than doing IPC.
The final priority order should be: BASIC < GDR < IPC < XTH.
lw
requested changes
Jan 18, 2021
| @@ -86,6 +86,8 @@ constexpr int64_t kBasicChannelPriority = 0; | |||
| #if TENSORPIPE_HAS_CUDA_IPC_CHANNEL && defined(USE_CUDA_NOT_ROCM) | |||
| constexpr int64_t kCudaIpcChannelPriority = 300; | |||
| constexpr int64_t kCudaXthChannelPriority = 400; | |||
| constexpr int64_t kCudaBasicChannelPriority = 500; | |||
There was a problem hiding this comment.
Oh and actually this should have a much lower priority, like 100. Otherwise we'll always prefer sending over TCP rather than doing IPC.
The final priority order should be: BASIC < GDR < IPC < XTH.
Differential Revision: [D25941963](https://our.internmc.facebook.com/intern/diff/D25941963) [ghstack-poisoned]
lw
approved these changes
Jan 18, 2021
Differential Revision: [D25941963](https://our.internmc.facebook.com/intern/diff/D25941963) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D25941963