[Bug] fix for module_has_exports

[cvluca]

The attributes in dir(mod) may not be valid, this will throw error when calling getattr.
Use hasattr to test if it is valid.

Here is an example:

class A:
    def __init__(self, x):
        if x:
            self._attr = 1

    @property
    def val(self):
        return getattr(self, '_attr')

a = A(False)
print('val' in dir(a))
print(hasattr(a, 'val'))

b = A(True)
print('val' in dir(b))
print(hasattr(b, 'val'))

And the outputs:

True
False
True
True

[facebook-github-bot]

Hi @cvluca!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[codecov]

Codecov Report

Merging #50680 (d9db39c) into master (1935880) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #50680      +/-   ##
==========================================
- Coverage   80.88%   80.88%   -0.01%     
==========================================
  Files        1931     1931              
  Lines      210560   210561       +1     
==========================================
- Hits       170312   170308       -4     
- Misses      40248    40253       +5     

[eellison]

Looks good, thanks for the PR! Mind adding a test so this doesn't regress in the future ?

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[eellison]

Great, thanks for the PR!!

[eellison]

Do you mind rebasing, looks like tests our failing due to merge conflicts ?

[cvluca]

Fixed, all green now!

[facebook-github-bot]

@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@eellison merged this pull request in 3f23ad5.