mem-efficient fake_quant: delete old version #50857
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Switches the default fake_quant path to use the new memory efficient backward from #50561. Separating for clean testing and review, but ideally we combine this with #50561. Test Plan: ``` python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cuda python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cuda ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jan 21, 2021
Summary: Switches the default fake_quant path to use the new memory efficient backward from #50561. Separating for clean testing and review, but ideally we combine this with #50561. Test Plan: ``` python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cuda python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cuda ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ba2787ee2a6b023bab36733ec32c91fb174f2cc7 Pull Request resolved: #50857
Summary: Switches the default fake_quant path to use the new memory efficient backward from #50561. Separating for clean testing and review, but ideally we combine this with #50561. Test Plan: ``` python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cuda python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cuda ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
vkuzo
added a commit
that referenced
this pull request
Jan 21, 2021
Summary: Switches the default fake_quant path to use the new memory efficient backward from #50561. Separating for clean testing and review, but ideally we combine this with #50561. Test Plan: ``` python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_forward_per_tensor_cuda python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cpu python test/test_quantization.py TestFakeQuantize.test_backward_per_tensor_cuda ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 7f15da247757c9423374bc32d0a8df8318308f68 Pull Request resolved: #50857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Switches the default fake_quant path to use the new memory efficient backward from
#50561.
Separating for clean testing and review, but ideally we combine
this with #50561.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: