New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
count_nonzero with requires grad #50866
Conversation
Hi @narain1! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #50866 +/- ##
==========================================
- Coverage 81.02% 81.01% -0.01%
==========================================
Files 1916 1916
Lines 209287 209287
==========================================
- Hits 169568 169558 -10
- Misses 39719 39729 +10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
will these changes also reflect on the XLA branch? |
This is the same code used by xla yes. Also the changes you pushed are unrelated right? I will remove them from the PR before landing. |
Yeah the last commit was a pr for a different issue I'm still figuring out to remove it😑 |
You can either:
|
No worries. |
Fixes #50792
fixes
count_nonzero
for tensors with requires_grad and also includes test