Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative prettyprinting method to Graph #50878

Closed
wants to merge 3 commits into from

Conversation

ansley
Copy link

@ansley ansley commented Jan 21, 2021

Stack from ghstack:

Differential Revision: D26009183

ansley pushed a commit that referenced this pull request Jan 21, 2021
ghstack-source-id: 003f9afb973dd2cc3a5f6e0776e2119adcb28502
Pull Request resolved: #50878
@ansley ansley requested a review from jamesr66a January 21, 2021 12:46
ansley pushed a commit that referenced this pull request Jan 21, 2021
ghstack-source-id: 815ed2e4951d379c4fca4e629ab57bc690d42705
Pull Request resolved: #50878
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things:

  1. tabulate is not a PyTorch dependency and it's probably not worth it to add it for this one function
  2. What benefit are folks getting from using print_IR rather than printing the Graph? My original suggestion was to incorporate whatever benefit they're getting from print_IR into the graph printout

ansley pushed a commit that referenced this pull request Jan 21, 2021
ghstack-source-id: 06b05e5ae284ce026a6aa39c0933706d03a54f2a
Pull Request resolved: #50878
@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #50878 (30d3d2f) into gh/ansleyadelaide/35/base (480bb7d) will decrease coverage by 0.31%.
The diff coverage is 14.28%.

@@                      Coverage Diff                      @@
##           gh/ansleyadelaide/35/base   #50878      +/-   ##
=============================================================
- Coverage                      81.01%   80.70%   -0.32%     
=============================================================
  Files                           1916     1916              
  Lines                         209285   209292       +7     
=============================================================
- Hits                          169562   168909     -653     
- Misses                         39723    40383     +660     

@facebook-github-bot
Copy link
Contributor

@ansley merged this pull request in 7f22af1.

@facebook-github-bot facebook-github-bot deleted the gh/ansleyadelaide/35/head branch January 25, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants