Make sure ConstantPadNd op preserves memory format #50898
Conversation
💊 CI failures summary and remediationsAs of commit 499d098 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #50898 +/- ##
==========================================
+ Coverage 80.91% 80.99% +0.08%
==========================================
Files 1925 1916 -9
Lines 210008 209538 -470
==========================================
- Hits 169919 169715 -204
+ Misses 40089 39823 -266 |
axitkhurana
force-pushed
the
fix-contant-pad-nd-memory-format
branch
from
f24e8df
to
f56e1bd
Compare
There was a problem hiding this comment.
@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
axitkhurana
force-pushed
the
fix-contant-pad-nd-memory-format
branch
from
f56e1bd
to
6796ec4
Compare
There was a problem hiding this comment.
@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: ConstantPadNd op didn't preserve memory format for non quantized cases Test Plan: pytest test/test_nn.py::TestConstantPadNd
axitkhurana
force-pushed
the
fix-contant-pad-nd-memory-format
branch
from
6796ec4
to
499d098
Compare
There was a problem hiding this comment.
@axitkhurana has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@axitkhurana merged this pull request in 16132a4. |
Summary:
Test Plan:
pytest test/test_nn.py::TestConstPadNd