Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[torch.futures] Clarify callback behavior when future is completed #50978

Closed
wants to merge 9 commits into from
Closed

[torch.futures] Clarify callback behavior when future is completed #50978

wants to merge 9 commits into from

Conversation

rohan-varma
Copy link
Member

@rohan-varma rohan-varma commented Jan 23, 2021 •
edited

Stack from ghstack:

Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: D25944636

@rohan-varma
[torch.futures] Clarify callback behavior when future is completed
310c02a 
Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 23, 2021 •
edited

💊 CI failures summary and remediations

As of commit e46362f (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This was referenced Jan 23, 2021
Closed
Closed
@rohan-varma rohan-varma mentioned this pull request Jan 23, 2021
Closed
mrshenli
mrshenli approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
5198882 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
ff4ba27 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
1aada71 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
8a17c5c 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
e947448 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
2c18f48 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
65e5142 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@rohan-varma
Update on "[torch.futures] Clarify callback behavior when future is c…
e46362f 
…ompleted"


Noticed that the documentation is not clear that the cbs are invoked
inline if the future is already completed. We should probably document this
behavior.

Differential Revision: [D25944636](https://our.internmc.facebook.com/intern/diff/D25944636/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 21afbba.

@facebook-github-bot facebook-github-bot deleted the gh/rohan-varma/220/head branch February 8, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrshenli mrshenli mrshenli approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rohan-varma @facebook-github-bot @mrshenli