Fix docstring to clarify logits usage for multiclass case #51053
Conversation
💊 CI failures summary and remediationsAs of commit add24ff (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
| 'logits': constraints.real} | ||
| support = constraints.real | ||
| 'logits': constraints.real_vector} | ||
| support = constraints.real_vector |
There was a problem hiding this comment.
LGTM. I'm not sure whether real_vector is the optimal constraint, but I believe it is the tightest valid constraint that we currently implement. I think that's fine since most users will use the wrapper class with the exact simplex constraint.
| 'logits': constraints.real} | ||
| support = constraints.real | ||
| 'logits': constraints.real_vector} | ||
| support = constraints.real_vector |
There was a problem hiding this comment.
LGTM. I'm not sure whether real_vector is the optimal constraint, but I believe it is the tightest valid constraint that we currently implement. I think that's fine since most users will use the wrapper class with the exact simplex constraint.
Codecov Report
@@ Coverage Diff @@
## master #51053 +/- ##
=======================================
Coverage 80.91% 80.91%
=======================================
Files 1925 1926 +1
Lines 210008 210019 +11
=======================================
+ Hits 169919 169947 +28
+ Misses 40089 40072 -17 |
There was a problem hiding this comment.
@neerajprad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@neerajprad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@neerajprad merged this pull request in e2041ce. |
Fixes #50378.
Additionally, this has some minor fixes:
infinstead ofnan.