Fixed SVD ignoring "some/full_matrices" flag for empty inputs #51109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For empty inputs
torch.svd
(andtorch.linalg.svd
) was returning incorrect results forsome=True
(full_matrices=False
).Behaviour on master branch:
some
flag is ignored and 7x7V
matrix is returned in both cases.V
should have 7x0 shape whensome=True
.This PR fixes that.