numeric suite: add types to eager #51168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds types to function I/O for numeric suite. This is for readability and static type checking with mypy. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 416ca5e (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
vkuzo
added a commit
that referenced
this pull request
Jan 27, 2021
Summary: Adds types to function I/O for numeric suite. This is for readability and static type checking with mypy. Test Plan: ``` mypy torch/quantization/ ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4441a698bda34be3acc4648b017673551ab18d0d Pull Request resolved: #51168
Codecov Report
@@ Coverage Diff @@
## gh/vkuzo/215/base #51168 +/- ##
=====================================================
- Coverage 80.87% 80.53% -0.35%
=====================================================
Files 1931 1931
Lines 210547 210548 +1
=====================================================
- Hits 170278 169555 -723
- Misses 40269 40993 +724 |
jerryzh168
approved these changes
Jan 27, 2021
|
This pull request has been merged in e9ffad0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Adds types to function I/O for numeric suite. This is for readability
and static type checking with mypy.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26092454