Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Add workflow to stale pull requests #51237

Closed
wants to merge 4 commits into from

Conversation

seemethere
Copy link
Member

@seemethere seemethere commented Jan 27, 2021

Stack from ghstack:

Stales pull requests at 150 days and then will close them at 180 days

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Differential Revision: D26112086

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 27, 2021

💊 CI failures summary and remediations

As of commit a56db71 (more details on the Dr. CI page):


  • 1/5 failures introduced in this PR
  • 4/5 broken upstream at merge base 6d09809 on Jan 27 from 12:00pm to 5:51pm

1 failure not recognized by patterns:

Job Step Action
CircleCI pytorch_windows_vs2019_py36_cuda10.1_test1 Test 🔁 rerun

🚧 4 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Jan 27, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

ghstack-source-id: d9ef8d4413afb264146f0ffc27e0abb6eb3981b9
Pull Request resolved: #51237

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@seemethere seemethere requested a review from yns88 January 27, 2021 21:02
Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As written, this seems like it will mark both PRs and issues as stale after six months, rather than only PRs; is that correct? If so, it should be changed to only act on PRs, not issues.

@yns88
Copy link
Contributor

yns88 commented Jan 27, 2021

Is it better to do this as our own GitHub Action, or to use the Stale app that's already installed in this org?

Looks like this PR hasn't been updated in a while! Going to go ahead and mark this as `stale`.
Feel free to update / remove the `stale` label if you feel this is a mistake
`stale` pull requests will automatically be closed 30 days after being marked `stale`
exempt-pr-labels: "no-stale"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add "open source" and "high priority" exemptions, then I think we can get more aggressive and close after as little as 3 months.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a separate job specifically for open source pull requests only

@seemethere
Copy link
Member Author

As written, this seems like it will mark both PRs and issues as stale after six months, rather than only PRs; is that correct? If so, it should be changed to only act on PRs, not issues.

The usage docs from the repository indicate that if no message for issues is designated then issues will not be marked stale.

Copy link
Contributor

@samestep samestep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage docs from the repository indicate that if no message for issues is designated then issues will not be marked stale.

Ah thanks, I missed that!

@seemethere
Copy link
Member Author

Is it better to do this as our own GitHub Action, or to use the Stale app that's already installed in this org?

I think using an action for this is better in the long run since it makes it transparent how / when it's called.

Stales pull requests at 150 days and then will close them at 180 days

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
Stales pull requests at 150 days and then will close them at 180 days

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Jan 27, 2021
Signed-off-by: Eli Uriegas <eliuriegas@fb.com>

ghstack-source-id: aa2675c7695ab221bc861018a237f81b6581cd01
Pull Request resolved: #51237

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@yns88
Copy link
Contributor

yns88 commented Jan 27, 2021

I think using an action for this is better in the long run since it makes it transparent how / when it's called.

Seems legit. Plus doing it this way lets us to different retentions for different sets of PRs, which doesn't seem possible with the Stale app.

@facebook-github-bot
Copy link
Contributor

@seemethere merged this pull request in cc211bb.

@facebook-github-bot facebook-github-bot deleted the gh/seemethere/50/head branch February 1, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants