-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: Add workflow to stale pull requests #51237
Conversation
Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit a56db71 (more details on the Dr. CI page):
1 failure not recognized by patterns:
🚧 4 fixed upstream failures:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
Signed-off-by: Eli Uriegas <eliuriegas@fb.com> ghstack-source-id: d9ef8d4413afb264146f0ffc27e0abb6eb3981b9 Pull Request resolved: #51237 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As written, this seems like it will mark both PRs and issues as stale after six months, rather than only PRs; is that correct? If so, it should be changed to only act on PRs, not issues.
Is it better to do this as our own GitHub Action, or to use the Stale app that's already installed in this org? |
Looks like this PR hasn't been updated in a while! Going to go ahead and mark this as `stale`. | ||
Feel free to update / remove the `stale` label if you feel this is a mistake | ||
`stale` pull requests will automatically be closed 30 days after being marked `stale` | ||
exempt-pr-labels: "no-stale" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add "open source" and "high priority" exemptions, then I think we can get more aggressive and close after as little as 3 months.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a separate job specifically for open source pull requests only
The usage docs from the repository indicate that if no message for issues is designated then issues will not be marked stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage docs from the repository indicate that if no message for issues is designated then issues will not be marked stale.
Ah thanks, I missed that!
I think using an action for this is better in the long run since it makes it transparent how / when it's called. |
Stales pull requests at 150 days and then will close them at 180 days Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
Stales pull requests at 150 days and then will close them at 180 days Signed-off-by: Eli Uriegas <eliuriegas@fb.com> [ghstack-poisoned]
Signed-off-by: Eli Uriegas <eliuriegas@fb.com> ghstack-source-id: aa2675c7695ab221bc861018a237f81b6581cd01 Pull Request resolved: #51237 Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
Seems legit. Plus doing it this way lets us to different retentions for different sets of PRs, which doesn't seem possible with the Stale app. |
@seemethere merged this pull request in cc211bb. |
Stack from ghstack:
Stales pull requests at 150 days and then will close them at 180 days
Signed-off-by: Eli Uriegas eliuriegas@fb.com
Differential Revision: D26112086