[reland][quant][graphmode][fx] Add support for functional conv1d and conv3d (#51155) #51254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…51155) Summary: This PR added support for quantizing functional conv1d, conv3d, conv1d_relu and conv3d_relu Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewed By: vkuzo [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Jan 28, 2021
…51155) Summary: This PR added support for quantizing functional conv1d, conv3d, conv1d_relu and conv3d_relu Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewed By: vkuzo ghstack-source-id: a2c4439b244f64533474d65a689435db5fe26f91 Pull Request resolved: #51254
💊 CI failures summary and remediationsAs of commit 1616286 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
jerryzh168
changed the title
…conv1d and conv3d (#51155)" Summary: This PR added support for quantizing functional conv1d, conv3d, conv1d_relu and conv3d_relu Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewed By: vkuzo Differential Revision: [D26116172](https://our.internmc.facebook.com/intern/diff/D26116172) [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Jan 28, 2021
…51155) Summary: This PR added support for quantizing functional conv1d, conv3d, conv1d_relu and conv3d_relu Test Plan: python test/test_quantization.py TestQuantizeFxOps.test_functional_conv Reviewed By: vkuzo ghstack-source-id: 8537b36cbdb26dbc503294c4f5148d3bef73152c Pull Request resolved: #51254
Codecov Report
@@ Coverage Diff @@
## gh/jerryzh168/535/base #51254 +/- ##
==========================================================
- Coverage 80.85% 80.53% -0.32%
==========================================================
Files 1931 1931
Lines 210932 210951 +19
==========================================================
- Hits 170542 169889 -653
- Misses 40390 41062 +672 |
|
This pull request has been merged in 7097c0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This PR added support for quantizing functional conv1d, conv3d, conv1d_relu and conv3d_relu
Test Plan:
python test/test_quantization.py TestQuantizeFxOps.test_functional_conv
Reviewed By: vkuzo
Differential Revision: D26116172