[quant][fx] Update name of packed weight attributes #51259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Store the FQN of the module that is using the packed weights (the quantized op) In the case of fusion we update the scope mapping to store the module path of the fused node. Test Plan: python test/test_quantization.py test_packed_weight_fused_op Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jan 28, 2021
Closed
💊 CI failures summary and remediationsAs of commit 3d85bc5 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Summary: Store the FQN of the module that is using the packed weights (the quantized op) In the case of fusion we update the scope mapping to store the module path of the fused node. Test Plan: python test/test_quantization.py test_packed_weight_fused_op Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26117964](https://our.internmc.facebook.com/intern/diff/D26117964) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Jan 28, 2021
Summary: Store the FQN of the module that is using the packed weights (the quantized op) In the case of fusion we update the scope mapping to store the module path of the fused node. Test Plan: python test/test_quantization.py test_packed_weight_fused_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9e8ff959d4b16ef44285005454b6029020e3be00 Pull Request resolved: #51259
Codecov Report
@@ Coverage Diff @@
## gh/supriyar/217/base #51259 +/- ##
=====================================================
Coverage 80.56% 80.57%
=====================================================
Files 1931 1931
Lines 210722 210729 +7
=====================================================
+ Hits 169775 169791 +16
+ Misses 40947 40938 -9 |
jerryzh168
reviewed
Jan 28, 2021
| 'call_function', qconv_op, qconv_args, kwargs) | ||
| quantizer.node_name_to_scope[op.name] = quantizer.node_name_to_scope[self.conv_node.name] |
There was a problem hiding this comment.
can you add a comment here? same for other occurrences
There was a problem hiding this comment.
Actually can you also add a TODO here:
"TODO: may need to change the key to Node regenerate the map in each transformation since we might not be able to rely on the name"
jerryzh168
approved these changes
Jan 28, 2021
Summary: Store the FQN of the module that is using the packed weights (the quantized op) In the case of fusion we update the scope mapping to store the module path of the fused node. Test Plan: python test/test_quantization.py test_packed_weight_fused_op Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26117964](https://our.internmc.facebook.com/intern/diff/D26117964) [ghstack-poisoned]
Summary: Store the FQN of the module that is using the packed weights (the quantized op) In the case of fusion we update the scope mapping to store the module path of the fused node. Test Plan: python test/test_quantization.py test_packed_weight_fused_op Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D26117964](https://our.internmc.facebook.com/intern/diff/D26117964) [ghstack-poisoned]
supriyar
added a commit
that referenced
this pull request
Jan 29, 2021
Summary: Store the FQN of the module that is using the packed weights (the quantized op) In the case of fusion we update the scope mapping to store the module path of the fused node. Test Plan: python test/test_quantization.py test_packed_weight_fused_op Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ef2ad948fe8e5c58067004ec93de01d9fe4ce688 Pull Request resolved: #51259
|
This pull request has been merged in 916af89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Store the FQN of the module that is using the packed weights (the quantized op)
In the case of fusion we update the scope mapping to store the module path of the fused node.
Test Plan:
python test/test_quantization.py test_packed_weight_fused_op
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D26117964