[complex] Enable complex autograd tests for diag
#51268
Conversation
💊 CI failures summary and remediationsAs of commit 3351d38 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #51268 +/- ##
===========================================
+ Coverage 68.02% 80.87% +12.84%
===========================================
Files 1785 1942 +157
Lines 179650 211448 +31798
===========================================
+ Hits 122204 171000 +48796
+ Misses 57446 40448 -16998 |
test/test_autograd.py
Outdated
| @@ -5037,7 +5037,7 @@ def run_functional_checks(test_case, test_name, name, apply_fn, run_grad_checks, | |||
| 'mean', 'inverse', 'triangular_solve', 'solve', 'addcmul', | |||
| 'addcdiv', 'linalg.tensorinv', 'matrix_exp', 'qr', | |||
| 'narrow', 'swapaxes', 'swapdims', 'tensor_split', 'tile', | |||
| 'baddbmm', 'addbmm', 'addmv'] + separate_complex_tests | |||
| 'baddbmm', 'addbmm', 'addmv', 'diag'] + separate_complex_tests | |||
There was a problem hiding this comment.
we are trying to not add tests in method_tests anymore. could you please add an OpInfo based test for diag?
anjali411
added
complex_autograd
module: complex
ailzhang
added
the
triaged
|
Hey @kshitij12345 looks like there are some merge conflicts. could you please rebase this PR? |
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
ahh merge conflicts again 😞 @kshitij12345 sorry could you rebase one more time? |
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@anjali411 merged this pull request in c39fb97. |
Reference: #33152