[dist_optim] update the doc of DistributedOptimizer #51314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating the doc of DistributedOptimizer to include TorchScript enablement information [ghstack-poisoned]
wanchaol
requested review from
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
cla signed
oncall: distributed
💊 CI failures summary and remediationsAs of commit ee114a2 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
updating the doc of DistributedOptimizer to include TorchScript enablement information [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Jan 28, 2021
updating the doc of DistributedOptimizer to include TorchScript enablement information ghstack-source-id: 27bef4af612876d4424b82ede068eafdf9df1461 Pull Request resolved: #51314
Codecov Report
@@ Coverage Diff @@
## gh/wanchaol/158/base #51314 +/- ##
========================================================
- Coverage 80.84% 80.50% -0.35%
========================================================
Files 1931 1931
Lines 210884 210884
========================================================
- Hits 170493 169775 -718
- Misses 40391 41109 +718 |
rohan-varma
approved these changes
Jan 29, 2021
torch/distributed/optim/optimizer.py
Outdated
| @@ -150,6 +150,13 @@ class DistributedOptimizer: | |||
| to the latest forward pass executed on a given worker. Also, there is no | |||
| guaranteed ordering across workers. | |||
|
|
|||
| DistributedOptimizer creates the local optimizer with TorchScript enabled | |||
There was a problem hiding this comment.
Nit: backticks for DistributedOptimizer
updating the doc of DistributedOptimizer to include TorchScript enablement information [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Jan 29, 2021
updating the doc of DistributedOptimizer to include TorchScript enablement information ghstack-source-id: 2fd88164f11550a21d8bf3e4f119c76e50641204 Pull Request resolved: #51314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
updating the doc of DistributedOptimizer to include TorchScript enablement information
Differential Revision: D26156032