New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ATen exported targets for consuming projects #5133
Conversation
@pytorchbot test this please |
I fixed the build error. This was caused by the THD_deps.txt file getting the name of the ATen target instead of the path to the library itself. Should be fixed now. |
@pytorchbot test this please |
@lantiga Is this PR still relevant? |
I think so, e.g. we can use this to load the aten cmake vars in the libtorch build instead of guessing. |
- Modified THD CMakeLists.txt to handle the fact that ${ATEN_LIBRARIES} are now imported targets. - Made cpuinfo and tbb_static private dependencies
Sorry I did not notice that the CI builds were failing. I rebased on master once more and I believe I fixed all the issues the previous commits had. |
@pytorchbot Test this please. Not sure if this will trigger the CI builds... |
@pytorchbot test this please |
@ezyang I believe the CI builds should pass with the latest commit. |
@pytorchbot test this please |
@pytorchbot retest this please |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
I added basic support for exported targets to make it easier for consuming projects to link to ATen. This is especially useful on Windows since both Release and Debug will work with the same install tree.
We may want to use
target_link_libraries(ATen PRIVATE ...)
with some dependencies but this is a start to make ATenConfig.cmake more complete.