Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ATen exported targets for consuming projects #5133

Closed
wants to merge 2 commits into from

Conversation

willyd
Copy link
Contributor

@willyd willyd commented Feb 8, 2018

I added basic support for exported targets to make it easier for consuming projects to link to ATen. This is especially useful on Windows since both Release and Debug will work with the same install tree.

We may want to use target_link_libraries(ATen PRIVATE ...) with some dependencies but this is a start to make ATenConfig.cmake more complete.

@ezyang
Copy link
Contributor

ezyang commented Feb 8, 2018

@pytorchbot test this please

@willyd
Copy link
Contributor Author

willyd commented Feb 8, 2018

I fixed the build error. This was caused by the THD_deps.txt file getting the name of the ATen target instead of the path to the library itself. Should be fixed now.

@ezyang
Copy link
Contributor

ezyang commented Feb 13, 2018

@pytorchbot test this please

@ezyang
Copy link
Contributor

ezyang commented Mar 23, 2018

@lantiga Is this PR still relevant?

@lantiga
Copy link
Contributor

lantiga commented Mar 23, 2018

I think so, e.g. we can use this to load the aten cmake vars in the libtorch build instead of guessing.
Right now we just assume standard *nix install locations, which means that libtorch won’t build on Windows.

- Modified THD CMakeLists.txt to handle the fact that
${ATEN_LIBRARIES} are now imported targets.

- Made cpuinfo and tbb_static private dependencies
@willyd
Copy link
Contributor Author

willyd commented Mar 26, 2018

Sorry I did not notice that the CI builds were failing. I rebased on master once more and I believe I fixed all the issues the previous commits had.

@willyd
Copy link
Contributor Author

willyd commented Mar 26, 2018

@pytorchbot Test this please. Not sure if this will trigger the CI builds...

@ezyang
Copy link
Contributor

ezyang commented Mar 26, 2018

@pytorchbot test this please

@willyd
Copy link
Contributor Author

willyd commented Mar 26, 2018

@ezyang I believe the CI builds should pass with the latest commit.

@ezyang
Copy link
Contributor

ezyang commented Mar 27, 2018

@pytorchbot test this please

@ezyang
Copy link
Contributor

ezyang commented Mar 28, 2018

@pytorchbot retest this please

@github-actions
Copy link

github-actions bot commented Mar 1, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

@github-actions github-actions bot added the Stale label Mar 1, 2022
@pytorchbot pytorchbot removed the Stale label Apr 12, 2022
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 11, 2022
@github-actions github-actions bot closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants