Fix: Bad autograd side effects from printing #51364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit c85aee0 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Codecov Report
@@ Coverage Diff @@
## master #51364 +/- ##
==========================================
- Coverage 80.84% 80.84% -0.01%
==========================================
Files 1931 1931
Lines 210933 210932 -1
==========================================
- Hits 170532 170529 -3
- Misses 40401 40403 +2 |
albanD
reviewed
Feb 1, 2021
There was a problem hiding this comment.
@jbschlosser has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@jbschlosser merged this pull request in 8f0968f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49756
Background
Fix applied here is to remove the grad enabled check from
collect_next_edges, unconditionally returning the actual collected edges. This pushes the responsibility for determining whether the function should be called without grad mode to its call-sites. With this update,collect_next_edgeswill no longer incorrectly return an empty list, which caused the problem described in the issue. Three call-sites depended on this behavior and have been updated.Beyond bad printing side effects, this fix addresses the more general issue of accessing
grad_fnwith grad mode disabled after an in-place operation on a view. The included test verifies this without the use of print.Test Plan