Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dirichlet.arg_constraints event_dim #51369

Closed
wants to merge 1 commit into from
Closed

Conversation

fritzo
Copy link
Collaborator

@fritzo fritzo commented Jan 29, 2021

This fix ensures

Dirichlet.arg_constraints["concentration"].event_dim == 1

which was missed in #50547

Tested

  • added a regression test, covering all distributions

@fritzo fritzo added the module: distributions Related to torch.distributions label Jan 29, 2021
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 29, 2021

💊 CI failures summary and remediations

As of commit 6d15dd3 (more details on the Dr. CI page):


  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neerajprad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #51369 (6d15dd3) into master (dbfaf96) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #51369      +/-   ##
==========================================
- Coverage   80.86%   80.85%   -0.01%     
==========================================
  Files        1938     1938              
  Lines      211184   211184              
==========================================
- Hits       170767   170763       -4     
- Misses      40417    40421       +4     

@facebook-github-bot
Copy link
Contributor

@neerajprad merged this pull request in 6465793.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants