Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix torch.cdist backward CUDA error due to illegal gridDim setting #51569

Closed
wants to merge 8 commits into from
Closed

Fix torch.cdist backward CUDA error due to illegal gridDim setting #51569

wants to merge 8 commits into from

Conversation

wanyu2018umac
Copy link
Contributor

@wanyu2018umac wanyu2018umac commented Feb 2, 2021 •
edited

Fixes #49928

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 2, 2021 •
edited

💊 CI failures summary and remediations

As of commit adcd32f (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

@wanyu2018umac wanyu2018umac mentioned this pull request Feb 2, 2021
Closed
@wanyu2018umac wanyu2018umac changed the title Cdist dev torch.cdist backward CUDA error due to illegal gridDim setting Feb 2, 2021
@wanyu2018umac wanyu2018umac mentioned this pull request Feb 2, 2021
Closed
@wanyu2018umac wanyu2018umac changed the title torch.cdist backward CUDA error due to illegal gridDim setting Fix torch.cdist backward CUDA error due to illegal gridDim setting Feb 2, 2021
@ngimel ngimel self-requested a review February 2, 2021 17:33
@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #51569 (adcd32f) into master (43084d7) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #51569      +/-   ##
==========================================
- Coverage   80.87%   80.87%   -0.01%     
==========================================
  Files        1943     1943              
  Lines      211503   211503              
==========================================
- Hits       171058   171048      -10     
- Misses      40445    40455      +10

@H-Huang H-Huang added module: cuda Related to torch.cuda, and CUDA support in general module: distance functions triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Feb 2, 2021
facebook-github-bot
facebook-github-bot reviewed Feb 3, 2021
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@ngimel merged this pull request in 444203c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@ngimel ngimel ngimel approved these changes

Assignees
No one assigned
Labels
cla signed Merged module: cuda Related to torch.cuda, and CUDA support in general module: distance functions open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CUDA error: invalid configuration argument during backward through torch.cdist
5 participants
@wanyu2018umac @facebook-github-bot @ngimel @H-Huang @pytorchbot