[FX] Added partial concrete values for symbolic tracing

[Chillee]

Currently it's passed in a dict but might be worth considering whether we want to support other methods of passing it in (like a list corresponding to the positional args).

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit b35108a (more details on the Dr. CI page):

---

• 5/6 failures introduced in this PR
• 1/6 broken upstream at merge base e54cbb8 from Feb 02 until Feb 03

---

🕵️ 5 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_linux_bionic_py3_6_clang9_test (1/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 03 15:26:51 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer" [override]

Feb 03 15:25:23 Test results will be stored in test-reports/python-unittest
Feb 03 15:25:31   test_doc_examples (__main__.TestTypeHints) ... ok (8.771s)
Feb 03 15:26:51   test_run_mypy (__main__.TestTypeHints) ... FAIL (79.220s)
Feb 03 15:26:51 
Feb 03 15:26:51 ======================================================================
Feb 03 15:26:51 FAIL [79.220s]: test_run_mypy (__main__.TestTypeHints) [mypy.ini]
Feb 03 15:26:51 ----------------------------------------------------------------------
Feb 03 15:26:51 Traceback (most recent call last):
Feb 03 15:26:51   File "test_type_hints.py", line 171, in test_run_mypy
Feb 03 15:26:51     self.fail(f"mypy failed: {stdout} {stderr}")
Feb 03 15:26:51 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer"  [override]
Feb 03 15:26:51 Found 1 error in 1 file (checked 1220 source files)
Feb 03 15:26:51  
Feb 03 15:26:51 
Feb 03 15:26:51 ----------------------------------------------------------------------
Feb 03 15:26:51 Ran 2 tests in 87.991s
Feb 03 15:26:51 
Feb 03 15:26:51 FAILED (failures=1)
Feb 03 15:26:51 
Feb 03 15:26:51 Generating XML reports...
Feb 03 15:26:51 Generated XML report: test-reports/python-unittest/TEST-TestTypeHints-20210203152523.xml

pytorch_linux_bionic_py3_8_gcc9_coverage_test1 (2/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 03 15:34:20 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer" [override]

Feb 03 15:32:52   test_run_mypy (__main__.TestTypeHints)
Feb 03 15:34:20 Runs mypy over all files specified in our mypy configs ... FAIL (88.830s)
Feb 03 15:34:20 
Feb 03 15:34:20 ======================================================================
Feb 03 15:34:20 FAIL [88.830s]: test_run_mypy (__main__.TestTypeHints) [mypy.ini]
Feb 03 15:34:20 Runs mypy over all files specified in our mypy configs
Feb 03 15:34:20 ----------------------------------------------------------------------
Feb 03 15:34:20 Traceback (most recent call last):
Feb 03 15:34:20   File "test_type_hints.py", line 171, in test_run_mypy
Feb 03 15:34:20     self.fail(f"mypy failed: {stdout} {stderr}")
Feb 03 15:34:20 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer"  [override]
Feb 03 15:34:20 Found 1 error in 1 file (checked 1220 source files)
Feb 03 15:34:20  
Feb 03 15:34:20 
Feb 03 15:34:21 ----------------------------------------------------------------------
Feb 03 15:34:21 Ran 2 tests in 98.513s
Feb 03 15:34:21 
Feb 03 15:34:21 FAILED (failures=1)
Feb 03 15:34:21 
Feb 03 15:34:21 Generating XML reports...
Feb 03 15:34:21 Generated XML report: test-reports/python-unittest/TEST-TestTypeHints-20210203153242.xml

pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test1 (3/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 03 15:53:49 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer" [override]

Feb 03 15:52:29 Test results will be stored in test-reports/python-unittest
Feb 03 15:52:37   test_doc_examples (__main__.TestTypeHints) ... ok (8.426s)
Feb 03 15:53:49   test_run_mypy (__main__.TestTypeHints) ... FAIL (72.507s)
Feb 03 15:53:49 
Feb 03 15:53:49 ======================================================================
Feb 03 15:53:49 FAIL [72.507s]: test_run_mypy (__main__.TestTypeHints) [mypy.ini]
Feb 03 15:53:49 ----------------------------------------------------------------------
Feb 03 15:53:49 Traceback (most recent call last):
Feb 03 15:53:49   File "test_type_hints.py", line 171, in test_run_mypy
Feb 03 15:53:49     self.fail(f"mypy failed: {stdout} {stderr}")
Feb 03 15:53:49 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer"  [override]
Feb 03 15:53:49 Found 1 error in 1 file (checked 1220 source files)
Feb 03 15:53:49  
Feb 03 15:53:49 
Feb 03 15:53:49 ----------------------------------------------------------------------
Feb 03 15:53:49 Ran 2 tests in 80.933s
Feb 03 15:53:49 
Feb 03 15:53:49 FAILED (failures=1)
Feb 03 15:53:49 
Feb 03 15:53:49 Generating XML reports...
Feb 03 15:53:49 Generated XML report: test-reports/python-unittest/TEST-TestTypeHints-20210203155229.xml

pytorch_linux_xenial_py3_clang5_asan_test1 (4/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 03 15:28:58 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer" [override]

Feb 03 15:27:20 Test results will be stored in test-reports/python-unittest
Feb 03 15:27:30   test_doc_examples (__main__.TestTypeHints) ... ok (10.833s)
Feb 03 15:28:58   test_run_mypy (__main__.TestTypeHints) ... FAIL (87.932s)
Feb 03 15:28:58 
Feb 03 15:28:58 ======================================================================
Feb 03 15:28:58 FAIL [87.932s]: test_run_mypy (__main__.TestTypeHints) [mypy.ini]
Feb 03 15:28:58 ----------------------------------------------------------------------
Feb 03 15:28:58 Traceback (most recent call last):
Feb 03 15:28:58   File "test_type_hints.py", line 171, in test_run_mypy
Feb 03 15:28:58     self.fail(f"mypy failed: {stdout} {stderr}")
Feb 03 15:28:58 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer"  [override]
Feb 03 15:28:58 Found 1 error in 1 file (checked 1220 source files)
Feb 03 15:28:58  
Feb 03 15:28:58 
Feb 03 15:28:58 ----------------------------------------------------------------------
Feb 03 15:28:58 Ran 2 tests in 98.766s
Feb 03 15:28:58 
Feb 03 15:28:58 FAILED (failures=1)
Feb 03 15:28:58 
Feb 03 15:28:58 Generating XML reports...
Feb 03 15:28:58 Generated XML report: test-reports/python-unittest/TEST-TestTypeHints-20210203152720.xml

pytorch_linux_xenial_py3_6_gcc5_4_test (5/5)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Feb 03 15:31:55 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer" [override]

Feb 03 15:30:40 Test results will be stored in test-reports/python-unittest
Feb 03 15:30:47   test_doc_examples (__main__.TestTypeHints) ... ok (7.594s)
Feb 03 15:31:55   test_run_mypy (__main__.TestTypeHints) ... FAIL (67.493s)
Feb 03 15:31:55 
Feb 03 15:31:55 ======================================================================
Feb 03 15:31:55 FAIL [67.493s]: test_run_mypy (__main__.TestTypeHints) [mypy.ini]
Feb 03 15:31:55 ----------------------------------------------------------------------
Feb 03 15:31:55 Traceback (most recent call last):
Feb 03 15:31:55   File "test_type_hints.py", line 171, in test_run_mypy
Feb 03 15:31:55     self.fail(f"mypy failed: {stdout} {stderr}")
Feb 03 15:31:55 AssertionError: mypy failed: torch/fx/experimental/rewriter.py:69: error: Signature of "trace" incompatible with supertype "Tracer"  [override]
Feb 03 15:31:55 Found 1 error in 1 file (checked 1220 source files)
Feb 03 15:31:55  
Feb 03 15:31:55 
Feb 03 15:31:55 ----------------------------------------------------------------------
Feb 03 15:31:55 Ran 2 tests in 75.087s
Feb 03 15:31:55 
Feb 03 15:31:55 FAILED (failures=1)
Feb 03 15:31:55 
Feb 03 15:31:55 Generating XML reports...
Feb 03 15:31:55 Generated XML report: test-reports/python-unittest/TEST-TestTypeHints-20210203153040.xml

---

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

• pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 from Feb 02 until Feb 03 (209e27e - 7918f37)
  • 🔁 rerun

---

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

[jamesr66a]

Please import and fix up any callsites internally before landing

[facebook-github-bot]

@Chillee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@Chillee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

@Chillee merged this pull request in 2d305b9.