Type-annotate tools/generate_torch_version #51637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add it to mypy.ini
malfet
added
module: typing
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
💊 CI failures summary and remediationsAs of commit 66be25d (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
 pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test2 |
Run tests | 🔁 rerun |
1 job timed out:
pytorch_linux_xenial_py3_clang5_asan_test1
This comment was automatically generated by Dr. CI (expand for details).
Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group.
samestep
approved these changes
Feb 3, 2021
| @@ -90,7 +90,7 @@ def get_and_check_clang_format(verbose=False): | |||
| # If the directory doesn't exist, try to create it. | |||
| try: | |||
| os.mkdir(CLANG_FORMAT_DIR) | |||
| except os.OSError as e: | |||
| except OSError as e: | |||
There was a problem hiding this comment.
why did this have the os. prefix before? I don't see a from os import OSError in the file currently so I'm a bit confused
There was a problem hiding this comment.
I don't know, found those while running mypy on the file.
walterddr
approved these changes
Feb 3, 2021
malfet
deleted the
malfet/add-type-annotatations-to-generate_torch_version.py
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add it to mypy.ini