Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beef up {jacobian, hessian} vectorize docs; eliminate a warning #51638

Closed
wants to merge 1 commit into from
Closed

Beef up {jacobian, hessian} vectorize docs; eliminate a warning #51638

wants to merge 1 commit into from

Commits on Feb 3, 2021

  1. Beef up {jacobian, hessian} vectorize docs; eliminate a warning 

    This PR makes the following doc changes:
- Makes it clear to users that they should use vectorize "at their own
risk"
- Makes it clear that vectorize uses the "experimental prototype vmap"
so that when users see error messages related to vmap they will know
where it is coming from.

This PR also:
- makes it so that {jacobian, hessian} call a version of vmap that
doesn't warn the user that they are using an "experimental prototype".
The regular torch.vmap API does warn the user about this. This is to
improve a UX a little because the user already knows from discovering
the flag and reading the docs what they are getting themselves into.

Test Plan:
- Add test that {jacobian, hessian} with vectorize=True don't raise
warnings

[ghstack-poisoned]
    @zou3519
    zou3519 committed Feb 3, 2021
    Configuration menu
    Copy the full SHA
    0cb72ed View commit details
    Browse the repository at this point in the history