Add FLOPS support to the new profiler API. #51734
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The new profiler API was added in PR#48280. This PR is to add FLOPS support to the new profiler API. Test Plan: ```python python test/test_profiler.py -k test_flops ```
💊 CI failures summary and remediationsAs of commit f3f7559 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ilia-cher
reviewed
Feb 4, 2021
ilia-cher
reviewed
Feb 4, 2021
ilia-cher
reviewed
Feb 4, 2021
ilia-cher
reviewed
Feb 4, 2021
xuzhao9
force-pushed
the
xzhao9/add-flops-new-profiler
branch
from
688810a
to
e9b0578
Compare
ilia-cher
reviewed
Feb 4, 2021
There was a problem hiding this comment.
@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…torch into xzhao9/add-flops-new-profiler
There was a problem hiding this comment.
@ilia-cher has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #51734 +/- ##
==========================================
- Coverage 80.91% 80.91% -0.01%
==========================================
Files 1948 1948
Lines 212343 212344 +1
==========================================
- Hits 171811 171810 -1
- Misses 40532 40534 +2 |
|
@ilia-cher merged this pull request in 5c3a054. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The new profiler API was added in PR#48280. This PR is to add FLOPS
support to the new profiler API.
Test Plan: