Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[quant] add docs for embedding/embedding_bag #51770

Closed
wants to merge 1 commit into from
Closed

[quant] add docs for embedding/embedding_bag #51770

wants to merge 1 commit into from

Conversation

supriyar
Copy link
Contributor

@supriyar supriyar commented Feb 5, 2021 •
edited

Stack from ghstack:

Summary:

Test Plan:
tested locally on mac

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D26279112

@supriyar
[quant] add docs for embedding/embedding_bag
dbf1ac8 
Summary:

Test Plan:
tested locally on mac

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 5, 2021 •
edited

💊 CI failures summary and remediations

As of commit dbf1ac8 (more details on the Dr. CI page):

  • 2/4 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)
  • 2/4 broken upstream at merge base 1065c2d on Feb 04 from 6:53pm to 11:36pm

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build binary_windows_libtorch_3_7_cpu_debug_build (1/1)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

FAILED: caffe2/CMakeFiles/torch_cpu.dir/__/torch/csrc/api/src/nn/options/instancenorm.cpp.obj 
caused by: Failed to read response header
caused by: failed to fill whole buffer
[3669/4114] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\__\torch\csrc\api\src\nn\options\activation.cpp.obj
FAILED: caffe2/CMakeFiles/torch_cpu.dir/__/torch/csrc/api/src/nn/options/activation.cpp.obj 
C:\w\b\windows\tmp_bin\sccache-cl.exe  /nologo /TP -DCPUINFO_SUPPORTED_PLATFORM=1 -DFMT_HEADER_ONLY=1 -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTH_BLAS_MKL -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -Dtorch_cpu_EXPORTS -Iaten\src -I..\..\aten\src -I. -I..\..\ -I..\..\cmake\..\third_party\benchmark\include -Icaffe2\contrib\aten -I..\..\third_party\onnx -Ithird_party\onnx -I..\..\third_party\foxi -Ithird_party\foxi -I..\..\torch\csrc\api -I..\..\torch\csrc\api\include -I..\..\caffe2\aten\src\TH -Icaffe2\aten\src\TH -Icaffe2\aten\src -Icaffe2\..\aten\src -Icaffe2\..\aten\src\ATen -I..\..\torch\csrc -I..\..\third_party\miniz-2.0.8 -I..\..\aten\src\TH -I..\..\aten\..\third_party\catch\single_include -I..\..\aten\src\ATen\.. -Icaffe2\aten\src\ATen -I..\..\caffe2\core\nomnigraph\include -I..\..\c10\.. -Ithird_party\ideep\mkl-dnn\include -I..\..\third_party\ideep\mkl-dnn\src\..\include -I..\..\third_party\pthreadpool\include -I..\..\third_party\cpuinfo\include -I..\..\third_party\fbgemm\include -I..\..\third_party\fbgemm -I..\..\third_party\fbgemm\third_party\asmjit\src -I..\..\third_party\FP16\include -I..\..\third_party\fmt\include -Ithird_party\gloo -I..\..\cmake\..\third_party\gloo -I..\..\cmake\..\third_party\googletest\googlemock\include -I..\..\cmake\..\third_party\googletest\googletest\include -I..\..\third_party\protobuf\src -IC:\w\b\windows\mkl\include -I..\..\third_party\XNNPACK\include -I..\..\third_party -I..\..\cmake\..\third_party\eigen -I..\..\cmake\..\third_party\pybind11\include -I..\..\third_party\ideep\mkl-dnn\include -I..\..\third_party\ideep\include -I..\..\caffe2 /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -DUSE_FBGEMM -DUSE_XNNPACK -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MDd /Z7 /Ob0 /Od /RTC1 /w /bigobj -DCAFFE2_USE_GLOO -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /Z7 /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -openmp:experimental -DCAFFE2_BUILD_MAIN_LIB -DONNX_BUILD_MAIN_LIB -std:c++14 /showIncludes /Focaffe2\CMakeFiles\torch_cpu.dir\__\torch\csrc\api\src\nn\options\activation.cpp.obj /Fdcaffe2\CMakeFiles\torch_cpu.dir\ /FS -c ..\..\torch\csrc\api\src\nn\options\activation.cpp
error: failed to execute compile
caused by: error reading compile response from server
caused by: Failed to read response header
caused by: failed to fill whole buffer
[3670/4114] Building CXX object caffe2\CMakeFiles\torch_cpu.dir\__\torch\csrc\api\src\nn\options\instancenorm.cpp.obj
FAILED: caffe2/CMakeFiles/torch_cpu.dir/__/torch/csrc/api/src/nn/options/instancenorm.cpp.obj 
C:\w\b\windows\tmp_bin\sccache-cl.exe  /nologo /TP -DCPUINFO_SUPPORTED_PLATFORM=1 -DFMT_HEADER_ONLY=1 -DIDEEP_USE_MKL -DMINIZ_DISABLE_ZIP_READER_CRC32_CHECKS -DONNXIFI_ENABLE_EXT=1 -DONNX_ML=1 -DONNX_NAMESPACE=onnx_torch -DTH_BLAS_MKL -DUSE_DISTRIBUTED -DUSE_EXTERNAL_MZCRC -DWIN32_LEAN_AND_MEAN -D_CRT_SECURE_NO_DEPRECATE=1 -D_OPENMP_NOFORCE_MANIFEST -Dtorch_cpu_EXPORTS -Iaten\src -I..\..\aten\src -I. -I..\..\ -I..\..\cmake\..\third_party\benchmark\include -Icaffe2\contrib\aten -I..\..\third_party\onnx -Ithird_party\onnx -I..\..\third_party\foxi -Ithird_party\foxi -I..\..\torch\csrc\api -I..\..\torch\csrc\api\include -I..\..\caffe2\aten\src\TH -Icaffe2\aten\src\TH -Icaffe2\aten\src -Icaffe2\..\aten\src -Icaffe2\..\aten\src\ATen -I..\..\torch\csrc -I..\..\third_party\miniz-2.0.8 -I..\..\aten\src\TH -I..\..\aten\..\third_party\catch\single_include -I..\..\aten\src\ATen\.. -Icaffe2\aten\src\ATen -I..\..\caffe2\core\nomnigraph\include -I..\..\c10\.. -Ithird_party\ideep\mkl-dnn\include -I..\..\third_party\ideep\mkl-dnn\src\..\include -I..\..\third_party\pthreadpool\include -I..\..\third_party\cpuinfo\include -I..\..\third_party\fbgemm\include -I..\..\third_party\fbgemm -I..\..\third_party\fbgemm\third_party\asmjit\src -I..\..\third_party\FP16\include -I..\..\third_party\fmt\include -Ithird_party\gloo -I..\..\cmake\..\third_party\gloo -I..\..\cmake\..\third_party\googletest\googlemock\include -I..\..\cmake\..\third_party\googletest\googletest\include -I..\..\third_party\protobuf\src -IC:\w\b\windows\mkl\include -I..\..\third_party\XNNPACK\include -I..\..\third_party -I..\..\cmake\..\third_party\eigen -I..\..\cmake\..\third_party\pybind11\include -I..\..\third_party\ideep\mkl-dnn\include -I..\..\third_party\ideep\include -I..\..\caffe2 /DWIN32 /D_WINDOWS /GR /EHsc /w /bigobj -DUSE_PTHREADPOOL -openmp:experimental -DUSE_FBGEMM -DUSE_XNNPACK -DHAVE_AVX_CPU_DEFINITION -DHAVE_AVX2_CPU_DEFINITION /MDd /Z7 /Ob0 /Od /RTC1 /w /bigobj -DCAFFE2_USE_GLOO -DUSE_GCC_GET_CPUID -DUSE_AVX -DUSE_AVX2 -DTH_HAVE_THREAD /Z7 /EHsc /DNOMINMAX /wd4267 /wd4251 /wd4522 /wd4838 /wd4305 /wd4244 /wd4190 /wd4101 /wd4996 /wd4275 /bigobj -openmp:experimental -DCAFFE2_BUILD_MAIN_LIB -DONNX_BUILD_MAIN_LIB -std:c++14 /showIncludes /Focaffe2\CMakeFiles\torch_cpu.dir\__\torch\csrc\api\src\nn\options\instancenorm.cpp.obj /Fdcaffe2\CMakeFiles\torch_cpu.dir\ /FS -c ..\..\torch\csrc\api\src\nn\options\instancenorm.cpp
error: failed to execute compile
caused by: error reading compile response from server
caused by: Failed to read response header
caused by: failed to fill whole buffer
ninja: build stopped: subcommand failed.
cmake -GNinja -DBUILD_ENVIRONMENT=libtorch 3.7 cpu debug -DBUILD_FOR_SYSTEM=windows -DBUILD_JNI=ON -DBUILD_PYTHON=False -DBUILD_PYTHONLESS=1 -DBUILD_TEST=True -DBUILD_TYPE=debug -DCMAKE_BUILD_TYPE=Debug -DCMAKE_GENERATOR=Ninja -DCMAKE_INCLUDE_PATH=C:\w\b\windows\mkl\include -DCMAKE_INSTALL_PREFIX=C:\w\b\windows\pytorch\torch -DCMAKE_PREFIX_PATH=C:\w\b\windows\conda\envs\py37\Lib\site-packages -DCUDA_NVCC_EXECUTABLE=C:\w\b\windows\tmp_bin\randomtemp.exe -DINSTALL_TEST=0 -DJAVA_HOME=C:/Users/circleci/project/.circleci/windows-jni/ -DNUMPY_INCLUDE_DIR=C:\w\b\windows\conda\envs\py37\lib\site-packages\numpy\core\include -DPYTHON_EXECUTABLE=C:\w\b\windows\conda\envs\py37\python.exe -DPYTHON_INCLUDE_DIR=C:\w\b\windows\conda\envs\py37\include -DUSE_CUDA=0 -DUSE_FBGEMM=1 -DUSE_NUMPY=True -DUSE_SCCACHE=1 C:\w\b\windows\pytorch
cmake --build . --target install --config Debug -- -j 16
Traceback (most recent call last):
  File "../tools/build_libtorch.py", line 20, in <module>

🚧 2 fixed upstream failures:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is older than viable/strict, run these commands:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

supriyar added a commit that referenced this pull request Feb 5, 2021
@supriyar
[quant] add docs for embedding/embedding_bag
0f012f1 
Summary:

Test Plan:
tested locally on mac

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: e402b5f3cbe158426ed118f307cad7e4dfe741bd
Pull Request resolved: #51770
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 59cb693.

@facebook-github-bot facebook-github-bot deleted the gh/supriyar/218/head branch February 9, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryzh168 jerryzh168 jerryzh168 approved these changes

@vkuzo vkuzo Awaiting requested review from vkuzo

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@supriyar @facebook-github-bot @jerryzh168