New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default arguments to cuda stream and events #53025
Conversation
💊 CI failures summary and remediationsAs of commit 564b408 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after a brief look; I'm assuming this is the same PR as last time.
Yeah thanks. Yes this is the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Codecov Report
@@ Coverage Diff @@
## master #53025 +/- ##
==========================================
- Coverage 78.01% 78.01% -0.01%
==========================================
Files 1848 1848
Lines 179696 179696
==========================================
- Hits 140192 140185 -7
- Misses 39504 39511 +7 |
…orch into new_add_default_args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nikithamalgifb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@nikithamalgifb merged this pull request in ab7f6f3. |
Summary: * **pytorch#53025 Add default args for CUDA stream and events** Tests: ===== python test/test_jit.py -v TestCUDA Pull Request resolved: pytorch#53025 Reviewed By: H-Huang Differential Revision: D26734499 Pulled By: nikithamalgifb fbshipit-source-id: 5311623a501e2e6fb3fc70e39522e3970e401feb
Summary: * **pytorch#53025 Add default args for CUDA stream and events** Tests: ===== python test/test_jit.py -v TestCUDA Pull Request resolved: pytorch#53025 Reviewed By: H-Huang Differential Revision: D26734499 Pulled By: nikithamalgifb fbshipit-source-id: 5311623a501e2e6fb3fc70e39522e3970e401feb
Tests:
python test/test_jit.py -v TestCUDA